Skip to content

Bump extern/ersem from 1f926cd to 2322ad7#42

Open
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/submodules/extern/ersem-2322ad7
Open

Bump extern/ersem from 1f926cd to 2322ad7#42
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/submodules/extern/ersem-2322ad7

Conversation

@dependabot
Copy link

@dependabot dependabot bot commented on behalf of github Feb 23, 2026

Bumps extern/ersem from 1f926cd to 2322ad7.

Commits
  • 2322ad7 Merge pull request #156 from pmlmodelling/155-release-2026-integration
  • e2f4f79 Updating fabm0d expected values
  • 29a9c8b Updating gotm expected values
  • 8086da1 removing DVM from pyfabm tests
  • 578cb77 adding docstrings and comments to DVM code
  • 17338ce Updating tests for new testcase yaml file structure
  • 8d1b890 Merge branch 'master' into 155-release-2026-integration
  • 8ca26d5 Merge pull request #160 from pmlmodelling/159_github_actions
  • f0815bc cosmetic changes
  • c04e793 Add comments for dvm
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [extern/ersem](https://github.com/pmlmodelling/ersem) from `1f926cd` to `2322ad7`.
- [Release notes](https://github.com/pmlmodelling/ersem/releases)
- [Commits](pmlmodelling/ersem@1f926cd...2322ad7)

---
updated-dependencies:
- dependency-name: extern/ersem
  dependency-version: 2322ad75c3697378e630a833b42a01eb4e9d5b0e
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code labels Feb 23, 2026
@jornbr
Copy link
Member

jornbr commented Feb 23, 2026

Hi @wathen, note the current fabm-plus test failures with the latest ERSEM update:

https://github.com/fabm-model/fabm-plus/actions/runs/22290493441/job/64476775807?pr=42#step:7:517

That's because now both nersc and ersem provide a dvm_upper_lower_boundaries module (and maybe other DVM related modules as well?) For this to work, both your module names will need to be unique (the main reason why ERSEM's original modules have the ersem_ prefix in their name) - so you might want to rename your version of the DVM modules. Or alternatively, work with nersc to deliver a unified DVM codebase that works both for ECOSMO and ERSEM, if that's within reach (@caglartac?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant