speedup has_comments_in_lines with binary search#800
Open
Conversation
reese
approved these changes
Jan 18, 2026
Collaborator
Author
|
Realized this morning that this is not quite right -- |
Owner
|
I have a concern that we're moving from a data structure that is inherently correct for this problem to one where we have to be careful about how we use it. Are we sure it's actually worth it here? |
7fc0ddf to
39c92a7
Compare
39c92a7 to
6d551a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't hit this code very often, but we might as well try to be fast when we do.
This way performs a little bit more work than necessary -- there is probably a smarter way to do this based on binary searching for the start and then the end of the range, and then deciding based on those results, but this way is more elegant.