Alembic skip topology #2751
Open
Alembic skip topology #2751
+148
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Interesting, lets discuss the design on discord please :) |
Contributor
Author
|
@mwestphal @Meakk @snoyer this PR is ready for a review. Thanks! |
Member
|
@Ni-g-3l please review |
mwestphal
reviewed
Jan 2, 2026
mwestphal
reviewed
Jan 2, 2026
mwestphal
reviewed
Jan 2, 2026
Contributor
Author
|
\ci fast |
Member
|
\ci full |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I added a cache to avoid rebuilding the entire mesh topology.
In case the topology is constant a lookup table is used to retrieve the object mesh, avoiding the call to PointDuplicateAccumulator which is expensive
Issue ticket number and link if any
Issure: #2719
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestamp\ci fast