-
-
Notifications
You must be signed in to change notification settings - Fork 361
scene hierarchy prototype #2509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
scene hierarchy prototype #2509
Conversation
|
You are modifying libf3d public API! |
0850d02 to
32a17a9
Compare
| /** | ||
| * Set a callback to request a render safely from within the render loop | ||
| */ | ||
| void SetRenderRequestCallback(std::function<void()> callback); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is needed. Without this callback, ImGui UI interactions wouldn't properly trigger re-renders. The callback is set up in window_impl.cxxband passed through vtkF3DRenderer → vtkF3DUIActor → vtkF3DImguiActor to enable safe render requests during the render loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im quite sure these is already a way to ImGui to trigger a safe render
37cdf50 to
979aaf2
Compare
|
Please ask for a review when needed @Medyan-Naser :) |
rebase
979aaf2 to
14d6e13
Compare
|
@mwestphal |
| ) | ||
|
|
||
| vtk_module_autoinit(TARGETS libf3d MODULES ${F3D_VTK_MODULES}) | ||
| vtk_module_autoinit(TARGETS libf3d MODULES ${F3D_VTK_MODULES} f3d::vtkextPrivate) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def should not be needed
| vtkTypeMacro(vtkF3DImguiActor, vtkF3DUIActor); | ||
|
|
||
| // Information key to track user-controlled visibility | ||
| static vtkInformationIntegerKey* USER_VISIBILITY(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this for ?
| { | ||
| std::vector<NodeInfo> nodes; | ||
|
|
||
| // Get scene hierarchy for GLTF files (where names are stored) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please note this will need to work with everything at the end, not gltf only
| #include "vtkF3DUserRenderPass.h" | ||
|
|
||
| #if F3D_MODULE_UI | ||
| #include "vtkF3DImguiActor.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use F3DUIActor instead
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes needed
|
Still working on this ? :) |
Describe your changes
Create prototype of scene hierarchy display and control using the vtkGLTFImporter
Issue ticket number and link if any
#2491
Checklist for finalizing the PR
.github/workflows/versions.json, I have updatedtimestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.