Conversation
There was a problem hiding this comment.
If service declaration is abstract, you don't need to set a class as it will never be instanciate
(working ex: https://github.com/prestaconcept/PrestaCMSCoreBundle/blob/master/Resources/config/block.xml#L18)
c4b6699 to
3e3a105
Compare
3e3a105 to
34642a5
Compare
|
|
||
| *Clearing*: When a operation is specifically affecting parent location(s), on tree operations `path` is more relevant. | ||
|
|
||
| - `path-<path-location-id>` |
There was a problem hiding this comment.
we'll need to expand here, and maybe update doc to reflect the code.
Side, we could also consider aligning with (one or the other way): https://github.com/ezsystems/ezpublish-kernel/compare/sf_cache#diff-e7db5fd1ab0e388fd87f6a8095599e22R277 and https://github.com/ezsystems/ezpublish-kernel/compare/sf_cache#diff-fb693bf163e578a01367f4466a44ad9bR316
There was a problem hiding this comment.
We can align. I'll have a look.
There was a problem hiding this comment.
Here is the list of tags I have extracted from the diff:
content-<contentId>
content-fields-<contentId>
content-fields-type-<typeId>
language-<id>
location-<locationId>
location-path-<locationId>
policy-<policyId>
role-<roleId>
role-assignment-<roleAssignmentId>
role-assignment-group-list-<contentId>
role-assignment-role-list-<roleId>
section-<sectionId>
state-<stateId>
state-group-<groupId>
type-group-<groupId>
type-map
type-<typeId>
urlAlias-location-<locationId>
urlAlias-global-<languageCode>
There was a problem hiding this comment.
That is correct, so
- are you ok with the naming convention? with domain first?
- shortened type to not make look like it is specifically content domain, even if they all are in a way.
- some here are very specific for persistence cache, like
content-fields,role-assignment-<list>andtype-map - main difference I guess with what is here now is the use of
location-path-over justpath-,oh and no use of content-type on content itself, maybe add something likeactually it fits well on type use as is,content-of-type-<type-id>instead for that, and I can adapt persistence to use that overcontent-fields-type-<type-id>type-<id>can be used for type cache, andcontent-type-<id>can be on the content of given type.
bdunogier
changed the title
andrerom
left a comment
andrerom
left a comment
There was a problem hiding this comment.
Besides doc improvements and tweaks that we can do in followup, +1
| $tags = []; | ||
|
|
||
| if (isset($signal->contentId)) { | ||
| // self in all forms (also withouth locations) |
|
Replaced by http://github.com/ezsystems/ezplatform-http-cache. Please do not delete the branch yet. |
3 participants
Adds tagging support to HttpCache Signal Slots. Each signal will send a purge request with the list of tags matching the operation it is registered for.
The main difference with #1772 is the removal of
purgeByTags()in favor ofpurge().TODO