This repository was archived by the owner on Sep 3, 2026. It is now read-only.
EZP-25482: Do not use CSRF token manager if not available - #1589
Merged
Merged
Conversation
Contributor
Author
|
If this needs to go against 6.1 branch please let me know :) |
Contributor
|
ideally yes :) |
Contributor
Author
|
Should I close this then and create a new PR? GitHub doesn't allow changing the destination branch :( |
Contributor
|
Either you re open, or we take care of it on merge (which we can do on simple changes like this). +1 |
Contributor
Author
|
If you can do a manual merge, that would be great :) I'll base my PRs in the future on 6.x branches ;) |
Contributor
Author
|
@andrerom This can be safely merged without waiting for ezsystems/PlatformUIBundle#515, right? |
andrerom
added a commit
that referenced
this pull request
Feb 25, 2016
EZP-25482: Do not use CSRF token manager if not available
Contributor
|
yes :) And since 6.2-rc will be out soon, there is no need to move it to 6.1. |
Contributor
Author
Why not? Would be useful to have it in 6.1 too (together with patch for Platform UI) |
Contributor
Author
|
Thanks, btw ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CSRF protection is disabled with
framework.csrf_protection.enabledflag set to false, site crashes with an exception about missingsecurity.csrf.token_managerservice.Required by: ezsystems/PlatformUIBundle#515