[WIP][Docker] Add support for using Varnish with xkey by andrerom · Pull Request #143 · ezsystems/ezplatform

andrerom · 2016-11-12T13:58:49Z

Varnish changes, ezplatform-http-cache package (uses varnsh xkey for improved varnish performance, and cache ability of our REST api++).

Todo:

Rebase on top of EZP-27542: Add support for using Varnish with Docker #188 once that is merged
Change to target 2.0 branch where ezplatform-http-cache is the default

andrerom · 2017-01-19T10:27:25Z

Back to passing, cleaned up and with last push it works locally as well again, super fast as always. /cc @bdunogier

How to tests (same exact steps as .travis.yml to know where to look next time you want to try):

check out branch
export TEST_CMD="bin/behat -vv --profile=rest --suite=fullJson --tags=~@broken" COMPOSE_FILE="doc/docker-compose/base-prod.yml:doc/docker-compose/redis.yml:doc/docker-compose/varnish.yml:doc/docker-compose/selenium.yml" BEHAT_WEB_HOST="varnish"
docker-compose -f doc/docker-compose/install.yml up --abort-on-container-exit
docker-compose up -d
Depending on your docker setup you should now be able to browse the install on localhost or some ip, where port 8080 is nginx, and 8081 is varish
if you don't change anything you can also run the behat tests for rest with docker-compose exec --user www-data app sh -c "php /scripts/wait_for_db.php; php $TEST_CMD" (one will fail because we registered redis here)

bdunogier · 2017-01-24T18:16:51Z

For readability, I'd suggest we split the ci/docker changes from the VCL ones (more like doc).

I can do it, @andrerom, just let me know.

bdunogier · 2017-01-24T18:24:49Z

From what I've seen, the VCL looks good. Haven't really looked at the docker part :)

andrerom · 2017-01-25T09:00:54Z

From what I've seen, the VCL looks good. Haven't really looked at the docker part :)

Should be easier now, just removed the duplicated vcl in entrypoint folder :D

andrerom · 2017-01-29T11:39:32Z

+            return (synth(405, "Method not allowed"));
+        }
+
+        # If http header "xkey" is set, we assume purge is on key and you have Varnish xkey installed


Align header name to be same on occurances here, in kernel and on foshttpcache pr, afaik it should be "key" like on line below and in foshttpcache

bdunogier · 2017-02-10T11:00:40Z

+# docker-compose exec varnish varnishlog -g request -q "ReqMethod eq 'PURGE'"
+#
+# But before doing that check that http and not local purge client is set:
+# docker-compose exec app app/console --env=dev debug:container ezpublish.http_cache.purge_client


Needs to be adapted to the service used by the http-cache package.

What does it need to be now?

bdunogier · 2017-02-10T11:01:22Z

        "incenteev/composer-parameter-handler": "~2.0",
        "tedivm/stash-bundle": "~0.4",
-        "ezsystems/ezpublish-kernel": "~6.7@dev",
+        "ezsystems/ezpublish-kernel": "dev-feature-EZP-25696 as 6.7.x-dev",


To be replaced with the enablement of the EzSystemsPlatformHttpCacheBundle in the AppKernel.

bdunogier · 2017-02-15T08:03:06Z

Given that the feature has been merged to ezsystems/ezplatform-http-cache, it has been decided that the VCL would go into the new package. I'll push a new version without the VCL changes. The Docker ones only make sense in this repository, don't they ?

I suggest that we leave the current varnish configuration untouched in this repository, and update the documentation to mention the external package and corresponding documentation.

andrerom · 2017-02-15T08:10:31Z

Given that the feature has been merged to ezsystems/ezplatform-http-cache, it has been decided that the VCL would go into the new package. I'll push a new version without the VCL changes. The Docker ones only make sense in this repository, don't they ?

yes, they only make sense here.

I suggest that we leave the current varnish configuration untouched in this repository, and update the documentation to mention the external package and corresponding documentation.

@bdunogier For 1.8 yes

But I think I'll leave this PR open with aim to at some point have official Varnish container, and ideally it should use the xkey variant of the VCL, so guess it will have to wait for version where we switch the default.

andrerom · 2017-09-05T15:05:32Z

Closing, solved in:

1.x (added xkey moduke to docker image): 2c946db
2.x (change to use ezplatform-http-cache and it's updated VCL): a83894c

andrerom mentioned this pull request Nov 12, 2016

[Docker] Add support for Varnish setup with Docker #142

Closed

2 tasks

andrerom changed the title ~~[Docker] Add docker support for using varnish with xkey~~ [Docker] Add docker support for using Varnish with xkey Nov 12, 2016

andrerom changed the title ~~[Docker] Add docker support for using Varnish with xkey~~ [Docker] Add support for using Varnish with xkey Nov 12, 2016

This was referenced Nov 14, 2016

[WIP] Feature EZP-25696: HTTPCache Multi Tagging/labeling ezsystems/ezpublish-kernel#1772

Closed

EZP-24854 EZP-26087 Update varnish configuration to purge required lo… #128

Closed

andrerom force-pushed the httpcache_varnish_tagging branch from 27e536e to c9047ea Compare November 23, 2016 17:17

andrerom force-pushed the httpcache_varnish_tagging branch from c9047ea to f2162c1 Compare December 16, 2016 22:20

andrerom force-pushed the httpcache_varnish_tagging branch 2 times, most recently from 25908fc to 69558c2 Compare January 19, 2017 10:22

andrerom force-pushed the httpcache_varnish_tagging branch from 69558c2 to 956e7c2 Compare January 25, 2017 09:00

andrerom commented Jan 29, 2017

View reviewed changes

andrerom mentioned this pull request Jan 30, 2017

HTTP cache multi-tagging purge client ezsystems/ezpublish-kernel#1894

Closed

3 tasks

bdunogier reviewed Feb 10, 2017

View reviewed changes

bdunogier mentioned this pull request Feb 15, 2017

Varnish 4 documentation & VCL ezsystems/ezplatform-http-cache#8

Merged

André R added 3 commits June 21, 2017 16:51

Enable EzSystemsPlatformHttpCacheBundle by default

b14ffbd

[Docker] Add docker support for using varnish with xkey

3ec5f21

Increase TTL to 900 and add some more info

57e6b34

andrerom force-pushed the httpcache_varnish_tagging branch from a571119 to 57e6b34 Compare June 21, 2017 15:30

[Travis] Run tests with varnish

98fc8e2

andrerom mentioned this pull request Jun 21, 2017

EZP-27542: Add support for using Varnish with Docker #188

Merged

andrerom changed the title ~~[Docker] Add support for using Varnish with xkey~~ [WIP][Docker] Add support for using Varnish with xkey Jun 22, 2017

andrerom closed this Sep 5, 2017

andrerom deleted the httpcache_varnish_tagging branch September 5, 2017 15:05

Navigation Menu

[WIP][Docker] Add support for using Varnish with xkey - #143

[WIP][Docker] Add support for using Varnish with xkey#143
andrerom wants to merge 4 commits into
masterfrom
httpcache_varnish_tagging

andrerom commented Nov 12, 2016 •

edited

Loading

Uh oh!

andrerom commented Jan 19, 2017 •

edited

Loading

Uh oh!

bdunogier commented Jan 24, 2017

Uh oh!

bdunogier commented Jan 24, 2017

Uh oh!

andrerom commented Jan 25, 2017

Uh oh!

andrerom Jan 29, 2017

Uh oh!

bdunogier Feb 10, 2017

Uh oh!

andrerom Feb 10, 2017 •

edited

Loading

Uh oh!

bdunogier Feb 10, 2017

Uh oh!

bdunogier commented Feb 15, 2017

Uh oh!

andrerom commented Feb 15, 2017 •

edited

Loading

Uh oh!

andrerom commented Sep 5, 2017

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

andrerom commented Nov 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrerom commented Jan 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bdunogier commented Jan 24, 2017

Uh oh!

bdunogier commented Jan 24, 2017

Uh oh!

andrerom commented Jan 25, 2017

Uh oh!

andrerom Jan 29, 2017

Choose a reason for hiding this comment

Uh oh!

bdunogier Feb 10, 2017

Choose a reason for hiding this comment

Uh oh!

andrerom Feb 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bdunogier Feb 10, 2017

Choose a reason for hiding this comment

Uh oh!

bdunogier commented Feb 15, 2017

Uh oh!

andrerom commented Feb 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrerom commented Sep 5, 2017

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

andrerom commented Nov 12, 2016 •

edited

Loading

andrerom commented Jan 19, 2017 •

edited

Loading

andrerom Feb 10, 2017 •

edited

Loading

andrerom commented Feb 15, 2017 •

edited

Loading