EZP-31647: more flexibility added to AttributeMapper::supports - #152
EZP-31647: more flexibility added to AttributeMapper::supports#152SerheyDolgushev wants to merge 1 commit into
Conversation
|
@alongosz can you please review this one? |
alongosz
left a comment
There was a problem hiding this comment.
I'm sorry, but I'm totally not following what you want here.
Are you requesting a feature or fixing a bug?
AttributeMapper is internal, thus there's no BC promise on that. It also implies that anything outside of its current function is not supported.
What do you need exactly?
|
It is a feature request. Let's say there are two custom tags with
Right now it is possible to have an attribute mapper for all the choice custom tag attributes. But it is impossible to have an attribute mapper for just a specific attribute of the specific custom tag. This PR provides this feature and will let to have an attribute mapper only for the @alongosz please let me know if you have any questions. |
|
Hmm, this feature (as always) can go in For now what is required are some configuration examples and unit test coverage. |
Before this PR
EzSystems\EzPlatformRichText\Configuration\UI\Mapper\CustomTag\AttributeMapper::supportswas accepting only$attributeName. But in some cases, it is vital to have attribute mappers for specific custom tags/attributes.TODO:
$ composer fix-cs).