This repository was archived by the owner on Sep 3, 2026. It is now read-only.
EZP-24854 EZP-26087 Update varnish configuration to purge required lo… - #32
Closed
benoitvidis wants to merge 1 commit into
Closed
benoitvidis wants to merge 1 commit into
benoitvidis wants to merge 1 commit into
Conversation
|
|
||
| if (req.http.X-Location-Id) { | ||
| ban("obj.http.X-Location-Id ~ " + req.http.X-Location-Id); | ||
| ban("obj.http.X-Location-Id ~ \b" + req.http.X-Location-Id) + "\b"; |
Contributor
There was a problem hiding this comment.
looks like a typo, the + "\b" should be inside the parenthesis of the ban function.
Contributor
|
Hi,
Also it has the potential to cause a regression if varnish config is not updated, so would definitely NEED a warning in update notes. ping @andrerom |
Contributor
|
It should indeed go to ezplatform repository, against 1.4 branch, and then we'll merge it in here. |
Member
|
@andrerom I will take care about pulling this changes from ezplatform to ezstudio meta. I'm closing this one. @benoitvidis could you open this PR against ezsystems/ezplatform repository so that we can merge it to ezstudio? |
Author
|
Sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cations only
cf https://jira.ez.no/browse/EZP-26087
The current implementation of varnish ban allows only one Location ID to be set in the X-Location-Id Header.
The proposal is to: