Skip to content
This repository was archived by the owner on Sep 3, 2026. It is now read-only.

RFC: Added information to Symfony's profiler "performance" tab for component rendering - #1751

Draft
Steveb-p wants to merge 2 commits into
2.2from
performance-tab
Draft

Steveb-p wants to merge 2 commits into
2.2from
performance-tab

Conversation

@Steveb-p

@Steveb-p Steveb-p commented May 7, 2021

Copy link
Copy Markdown
Contributor
Question Answer
Tickets N/A
Bug fix? no
New feature? yes
BC breaks? no
Doc needed? no
License GPL-2.0

This PR adds dev mode decoration for one the services, which adds debug.stopwatch around the method calls to add them into performance tab in Symfony's profiler.

This also changes the renderer to emit both group and single events, when iterating over group components for rendering.

image

WDYT?

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@Steveb-p
Steveb-p changed the base branch from master to 2.2 May 7, 2021 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant