Skip to content
This repository was archived by the owner on Sep 3, 2026. It is now read-only.

EZP-31321: Dropped injecting zero-width space into ezembed(inline) elements - #1151

Merged
lserwatka merged 2 commits into
ezsystems:1.5from
SerheyDolgushev:fix_embed_zero_width_space
Jan 22, 2020
Merged

lserwatka merged 2 commits into
ezsystems:1.5from
SerheyDolgushev:fix_embed_zero_width_space

Conversation

@SerheyDolgushev

@SerheyDolgushev SerheyDolgushev commented Dec 2, 2019

Copy link
Copy Markdown
Contributor
Question Answer
Tickets EZP-31321, related to EZP-29882
Requires ezsystems/ezplatform-richtext#88
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Parent PR: ezsystems/ezplatform-richtext#88.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@SerheyDolgushev

Copy link
Copy Markdown
Contributor Author

Zero width space seems to also cause some issues with Solr indexing:

org.apache.solr.common.SolrException: Illegal character ((CTRL-CHAR,​ code 14))

@lserwatka

Copy link
Copy Markdown
Member

@alongosz @adamwojs could you have a final look on this one?

@alongosz
alongosz requested a review from dew326 January 16, 2020 15:13
@alongosz alongosz changed the title Dont use zero width sapce for EZP-29882 Dropped injecting zero-width space into ezembed(inline) elements Jan 21, 2020
@alongosz alongosz changed the title Dropped injecting zero-width space into ezembed(inline) elements EZP-31321: Dropped injecting zero-width space into ezembed(inline) elements Jan 21, 2020
@alongosz
alongosz force-pushed the fix_embed_zero_width_space branch from 2091e30 to 1cdf8b3 Compare January 21, 2020 11:01
@micszo micszo self-assigned this Jan 22, 2020

@micszo micszo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.8 with branches.

@micszo micszo removed their assignment Jan 22, 2020
@lserwatka
lserwatka merged commit 30ea995 into ezsystems:1.5 Jan 22, 2020
@lserwatka

Copy link
Copy Markdown
Member

@dew326 could you merge it up?

@dew326

dew326 commented Jan 22, 2020

Copy link
Copy Markdown
Member

@lserwatka done

alongosz pushed a commit to ezsystems/ezplatform-richtext that referenced this pull request Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

6 participants