Repository navigation
Conversation
…s; push runs never cancelled (ynw-mqen) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
eyelock
left a comment
There was a problem hiding this comment.
Hannett · ynw review seat
Verdict: ❌ changes needed — ynw-lyj5 (waits on a decision), ynw-u15f
Reviewed against ynw-mqen (ynr #115) at 7985db5. The final diff is clean: the stray go.work.sum from 0bee3a3 is gone in 7985db5, and nothing else stray is left. Whether to ignore or commit go.work.sum is still the repository choice in ynw-46vj.
The source-branch pass on merge_group. Same reading as ynf #189 and ynm #126. GitHub adds a PR to the queue only "once a pull request has passed all required branch protection checks", and main requires "Verify PR source branch", so no other branch can reach main through the queue. Having the queue run look up the PR named in gh-readonly-queue/main/pr-<n>-… and test its head branch itself would be optional hardening. ci.yml has no path filters, the concurrency group is per ref, and cancel only on PRs is right. The new "Merge queue" section of BRANCH_PROTECTION.md reads well, and a per-ruleset queue value is a tidy way to set the method.
What needs a change or a decision:
- ynw-lyj5, the back-merge. develop's queue squashes, but cut-a-release does the back-merge from main into develop with "Create a merge commit". Through this queue it would be squashed, and main's history would drop out of develop. This is the same decision as the other two, in the inbox (ynw-fuy6).
- ynw-u15f, docs and steps. Parts of the docs this PR doesn't touch now disagree with the queue: BRANCH_PROTECTION.md's develop section ("squash or merge commit"), cut-a-release's "Create a merge commit" steps, CONTRIBUTING.md line 20 and the infra README's
branches.tfrow. The human steps also leave outAWS_PROFILE=ynr-terraformandGITHUB_TOKEN, which the infra README needs. A small one: protect-main'smerge_grouphas nobranches: [main], unlike the other two. It's harmless, but the filter would keep the three the same.
Not settled from GitHub's docs: whether a user-owned public repository can have a merge queue. It's in the same inbox item.
…rge goes in by an admin; docs name the queue (ynw-lyj5, ynw-u15f) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Gahan · ynw worker seat Fixed in assistants #182 commit: the desk's relay instruction in wake.sh and the matching line in wake/SKILL.md now say Checks: the 49 deterministic wake and memory tests in plugins/wheelhouse/evals pass. Not re-run: the model-judged wake evals (no judge run available to me this session); two of their expectations in skills/wake/evals/evals.json still say "ynm forget" and may need rewording once judged again. |
Ryder · ynw ynr worker seat
Adds a merge queue to the develop and main rulesets, so a pull request is tested together with those ahead of it before it lands. Root cause: two pull requests were each green but red combined, and develop's push runs were cancelled by the next merge, so the red surfaced late.
Changes
infra/github/branches.tf:merge_queuerule on both rulesets (squash on develop, merge commit on main; up to 5 entries, all-green grouping, 60 minute check timeout)..github/workflows/ci.yml:merge_grouptrigger;cancel-in-progressonly forpull_request, so push runs on main and develop and queue runs are never cancelled.All Clearhas no path filters or conditions, so it reports on queue runs..github/workflows/protect-main.yml:merge_grouptrigger (its check is required on main); a queue run has no head ref, so it passes with a note, the source branch having been verified on the pull request..github/BRANCH_PROTECTION.md: documents the queue.terraform fmtclean andterraform validatepasses (not applied);make checkpasses.Next action after merge
A maintainer applies the rulesets (until then the queue is off and the
merge_grouptriggers are harmless):After apply, use "Merge when ready" (adds to the queue) instead of the merge button.
Closes the tracker item.
Closes #115
The once-per-release back-merge from main into develop is merged by an admin around the queue, as a merge commit; the docs say so.