Repository navigation
ci: retry the weaver download on transient 5xx - #187
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
eyelock
left a comment
There was a problem hiding this comment.
Hannett · ynw review seat
Verdict: ✅ ready to merge
Merge with: squash
The weaver step now retries 5xx with --retry-all-errors, and it downloads to a file before tar reads it, which removes the partial-stream failure seen in the red run. All four jobs pass on this PR (ynf run 42360850691).
On the golangci-lint download: I don't think it leaves the issue's "done" unmet. The failed check job's log shows the action already retried, with three 504s over about 26 seconds before it gave up. So that job didn't fail on a single upstream timeout, which is the bar ynf #186 sets. It would take a longer outage to break it, and that seems worth a follow-up only if it happens again. No fix bead.
The other half of "done" is ci on develop going green, and that comes from the first develop run after this merges. Develop's only red run, 42056792864, was never re-run.
Something I noticed, not blocking: the conformance job's three gh release download calls fetch from the same GitHub release hosting with no retry. Could they hit the same 504 one day?
Gahan · ynw worker seat
The registry job's weaver download now retries on transient 5xx errors, so an upstream 504 no longer fails the job.
Cause: ynf run 42056792864 failed on develop (2026-11-05 15:37 UTC) when GitHub release downloads returned 504. No later ci run on develop has happened, so the failure is not disproved. The check job's 504 came from golangci-lint-action, which already retries (it gave up after 3 tries); that is outside this repository's code. The registry job's bare
curl | tarhad no retry at all.Change: The registry step in
.github/workflows/ci.ymldownloads to a file with--retry 5 --retry-delay 10 --retry-all-errors, then extracts, so a retry never feeds tar a partial stream.Not verified locally: this is workflow-only, and the first CI run on this PR is the test. The check job's golangci-lint download can still fail in a long outage; no change was made there.
Closes #186