Update index.php#1
Conversation
Lines 531 to 535 have been edited and debugged.
eyedean
left a comment
eyedean
left a comment
There was a problem hiding this comment.
I would also recommend picking a better commit and PR title. Thank you @Bamdad-Kr
| // if (($rate < 1) || ($rate > 5)) | ||
| // $rating[1] = "0/0"; | ||
| // if (isset($rating[2])) | ||
| // $curLastVisit = $rating; |
There was a problem hiding this comment.
Why are we commenting these lines out? 🤔
There was a problem hiding this comment.
I wanted to avoid losing the original version of this piece. However, I realized that I could review the previous versions, so I removed the comments.
There was a problem hiding this comment.
It seems like you removed those lines instead of un-commenting them (to become like the original version).
There was a problem hiding this comment.
That's right. I'm sorry for the mistake.
+An indentation was added in line 534.
| if (isset($rating[2])) | ||
| $curLastVisit = $rating; | ||
|
|
||
| //secondary version: |
There was a problem hiding this comment.
I am not sure if this comment serves any purpose.
There was a problem hiding this comment.
You're right. I've removed it.
| if (($rate < 1) || ($rate > 5)) | ||
| $rating[1] = "0/0"; | ||
| if (isset($rating[2])) | ||
| $curLastVisit = $rating; |
There was a problem hiding this comment.
I am not sure why these two ifs are removed.
The second (which sets $curLastVisit) is weird. But the first one has been there to correct any incorrect rating.
Is there any special reason that they are removed?
2 participants
Lines 531 to 535 have been edited and debugged.