Refactor cookie-mode anonymous history hand-off - #144
Open
akshatmalik-bruh wants to merge 1 commit into
Open
akshatmalik-bruh wants to merge 1 commit into
akshatmalik-bruh wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes the issue where the frontend was forced to guess when an anonymous visitor logged into a cookie-authenticated host app by repeatedly polling
POST /auth/linkand receiving401 Unauthorizedresponses. This guessing game resulted in unnecessary network spam, latency, and a fragile dependency on window/cookie events.fixes #131
What Changed
Implemented Server-Side Opportunistic Hand-off. The server is now the authoritative source of truth for when an authenticated session begins.
Backend (
deps.py)X-Extra-Visitor-Passheader.get_principalintercepts this header. If the request has an authenticated session cookie and a visitor pass header, the backend opportunistically callslink_anonymousbefore serving the request.Frontend (
tokenSource.ts&AgentChatClient.ts)identityCheckDirty,cookieSnapshotChanged,forceCheck, and focus/visibility/storage event listeners).POST /auth/linkprobes in cookie mode.AgentChatClientsimply attaches theX-Extra-Visitor-Passheader to everyfetch.Verification
test_api.pycovering all edge cases (immediate login, already-adopted pass, invalid pass, concurrent requests, bearer mode preservation).make checkpasses perfectly (linting, typechecking, and all 57 tests).