fix: correctly bind async local plugins as coroutines - #143
Open
akshatmalik-bruh wants to merge 1 commit into
Open
akshatmalik-bruh wants to merge 1 commit into
akshatmalik-bruh wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Currently, a local plugin implemented as
async defis accepted during the engine build but never actually executes. The engine records the tool call assucceededand hands the LLM a stringified coroutine object instead of the actual resolved value. This causes a P2 silent no-op.fixes #141
The root cause was that
GraphBuilder._build_agent_toolswas passing all functions throughStructuredTool.from_function(function). This registers async functions in the synchronousfuncslot, which LangChain's synchronous execution path returns instead of awaiting.Solution
Updated
GraphBuilder._build_agent_toolsto properly detect async functions usinginspect.iscoroutinefunction(function).coroutine=function.func=function.Testing and Verification
tests/test_review_regression.py) that mocks a model and verifies that theasync defbody physically executes and writes to disk.make checkand verified that formatting, linting, type-checking, and all tests pass locally.