chore: add http headers to HttpResponse interface - #138
Conversation
|
Thanks! What do you think about making this optional / nullable? Since the feature requires that the host has allowed http headers in responses, it's probably best to indicate that these may not be se at all and use the type system to encourage users to program around that possibility. |
I have mostly used the chicory sdk so far and there the headers don't seem to be configurable. |
|
@evacchi - mind taking a look re: chicory? maybe we made that the default, to always pass the response headers - but if I recall, it was the opposite in other SDKs. |
|
Yes that feature (response headers) is currently not available in the chicory sdk EDIT sorry fat-fingered close |
|
ok double-checked, and I confirm that the feature is available, but it's currently not configurable, addressed with extism/chicory-sdk#65 |
|
Hey @nilslice, are we good to get this merged in? 🤞 |
|
@evacchi & @chrisdickinson are coordinating a release and some dependent updates, but yes this is otherwise good to go. will merge and release soon! |
follow-up to #101 and #103.
while #103 changes the javascript object, it is not exposed in the typescript types.