Skip to content

chore: add http headers to HttpResponse interface - #138

Merged
chrisdickinson merged 2 commits into
extism:mainfrom
BSchneppe:chore/add-http-headers-to-typescript-types
Oct 24, 2025
Merged

chore: add http headers to HttpResponse interface#138
chrisdickinson merged 2 commits into
extism:mainfrom
BSchneppe:chore/add-http-headers-to-typescript-types

Conversation

@BSchneppe

Copy link
Copy Markdown
Contributor

follow-up to #101 and #103.
while #103 changes the javascript object, it is not exposed in the typescript types.

@nilslice

Copy link
Copy Markdown
Member

Thanks!

What do you think about making this optional / nullable? Since the feature requires that the host has allowed http headers in responses, it's probably best to indicate that these may not be se at all and use the type system to encourage users to program around that possibility.

@BSchneppe

Copy link
Copy Markdown
Contributor Author

Thanks!

What do you think about making this optional / nullable? Since the feature requires that the host has allowed http headers in responses, it's probably best to indicate that these may not be se at all and use the type system to encourage users to program around that possibility.

I have mostly used the chicory sdk so far and there the headers don't seem to be configurable.

@nilslice

Copy link
Copy Markdown
Member

@evacchi - mind taking a look re: chicory?

maybe we made that the default, to always pass the response headers - but if I recall, it was the opposite in other SDKs.

@evacchi

evacchi commented Sep 30, 2025

Copy link
Copy Markdown

Yes that feature (response headers) is currently not available in the chicory sdk

EDIT sorry fat-fingered close

@evacchi

evacchi commented Oct 1, 2025

Copy link
Copy Markdown

ok double-checked, and I confirm that the feature is available, but it's currently not configurable, addressed with extism/chicory-sdk#65

@lolletsoc

Copy link
Copy Markdown

Hey @nilslice, are we good to get this merged in? 🤞

@nilslice

Copy link
Copy Markdown
Member

@evacchi & @chrisdickinson are coordinating a release and some dependent updates, but yes this is otherwise good to go. will merge and release soon!

@chrisdickinson
chrisdickinson merged commit 8963025 into extism:main Oct 24, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants