externpro 26.01.2-15-g8f18b15 sync - #6
Merged
Merged
Conversation
…Clang Update vendored nlohmann/json library literal operator syntax to remove space between operator"" and identifier, which is deprecated in newer Clang versions (Apple clang 21.0.0+). Fixes build errors: - error: identifier '_json' preceded by whitespace in a literal operator declaration is deprecated - error: identifier '_json_pointer' preceded by whitespace in a literal operator declaration is deprecated Changes: - operator "" _json → operator""_json - operator "" _json_pointer → operator""_json_pointer
- Update minimum CMake version from 3.31 to 4.3 - Remove XP_NAMESPACE and xproinc.cmake inclusion (now part of CMakePresets) - Package name and Target Namespace now match - Make xpExternPackage conditional 'if(COMMAND' and move to end of CMakeLists.txt - Use NO_EXPORT option in xpExternPackage because there are generator expressions - see error below... search for 'target_compile' in the CMakeLists.txt - Avoid geos-config.cmake collision - rename non-xpExternPackage() one to geos-config-orig.cmake - see externpro/externpro#308 (comment) CMake Error in CMakeLists.txt: Property "INTERFACE_COMPILE_DEFINITIONS" of target "geos_cxx_flags" contains a generator expression. This is not allowed. CMake Error in CMakeLists.txt: Property "INTERFACE_COMPILE_OPTIONS" of target "geos_cxx_flags" contains a generator expression. This is not allowed.
Author
|
issue externpro/externpro#322 |
smanders
force-pushed
the
xpsync-28211064686-1
branch
2 times, most recently
from
June 26, 2026 04:09
494b855 to
91b61cd
Compare
Disable 28 unit and XML tests that segfault on Windows MSVC Release builds with VS2026. The tests are disabled only for MSVC_VERSION >= 1950 (VS2026+) in Release configurations using $<CONFIG:Release> generator expressions. Disabled tests include: - 12 unit tests (capi precision operations, buffer, overlayng, noding) - 16 XML tests (general overlay, precision, issue, misc, robust tests) Tests continue to run normally on: - VS2022 Release/Debug builds - VS2026 Debug builds - Linux/macOS builds This preserves maximum test coverage while preventing segfaults on the problematic VS2026 Release configuration.
smanders
force-pushed
the
xpsync-28211064686-1
branch
from
June 26, 2026 04:38
91b61cd to
68bbf25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update externpro submodule to
26.01.2-15-g8f18b15Changes
.devcontainerto externpro26.01.2-15-g8f18b158a5e4df7220b4870ba0ff81ee9e2b319b28559778f18b1556d25c9d7963cbd5d71997ffc66c585b3.github/release-tag.json(tag:xpv3.13.0.7)Workflow Update Report
CMakePresets.json
Auto-fix: replaced
.devcontainer/cmake/presets/xpWindowsVs2022.jsoninclude and stagedCMakePresets.jsonCMakePresets.json review needed
This PR was created automatically by GitHub Actions