fix: Static library compilation in podspec#140
Open
steve228uk wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
USE_FRAMEWORKS=static.Issues Resolved
Static framework iOS builds could fail because Objective-C sources attempted to import
react_native_exponea_sdk-Swift.hbefore Xcode exposed it reliably.The previous direct
pod_target_xcconfig[...]approach could also fail duringpod installbecause CocoaPods exposespod_target_xcconfig=as a writer, but not as a readable hash accessor.When overriding pod target config for static framework builds, the podspec must continue to carry React Native's configured clang C++ language standard so the target stays aligned with the React Native build settings.
How
pod_target_xcconfigfroms.attributes_hash.HEADER_SEARCH_PATHS.$(inherited)when no header search paths are already present.s.pod_target_xcconfig = ....CLANG_CXX_LANGUAGE_STANDARDtorct_cxx_language_standard().SWIFT_COMPILATION_MODEset toincrementalfor static framework builds.SWIFT_OBJC_INTERFACE_HEADER_NAMEtoreact_native_exponea_sdk-Swift.h.Validation
git diff --checkruby -c react-native-exponea-sdk.podspec