fix: memory leak in embedded Snack - #697
Open
SimonSiefke wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Inline embedded Snacks register a global
messagecallback that captures their iframe while waiting forexpoFrameLoaded. When a host removes the container during client-side navigation, the callback stays registered and keeps the detached iframe reachable.Change
Track pending callbacks per iframe, unregister them after the handshake or explicit removal, and observe host-driven DOM removal so abandoned embeds are cleaned up. Register the callback before insertion to avoid missing a synchronous load message.
Before
When navigating between the React Native Introduction and Core Components pages 37 times, the embedded Snack message callback grows by 74:
After
No more matching embedded Snack message callback growth is detected.
Test Video
react-native-docs-core-components.webm