[cli] CI check and environment flag override for update#3442
Open
douglowder wants to merge 1 commit intomainfrom
Open
[cli] CI check and environment flag override for update#3442douglowder wants to merge 1 commit intomainfrom
douglowder wants to merge 1 commit intomainfrom
Conversation
|
Subscribed to pull request
Generated by CodeMention |
94adb8d to
c914a38
Compare
|
✅ Thank you for adding the changelog entry! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3442 +/- ##
==========================================
+ Coverage 52.78% 52.79% +0.01%
==========================================
Files 809 809
Lines 34047 34053 +6
Branches 7075 7076 +1
==========================================
+ Hits 17969 17975 +6
Misses 15997 15997
Partials 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Provide a way to override the new requirement for the
--environmentflag ineas update.How
Modify the check to skip when the
EAS_UPDATE_SKIP_ENVIRONMENT_CHECKvariable is set to a boolish value (1 or true).Add the
CIflag to the tests for whether we should skip the check in a CI environment.Test Plan
New unit tests added.