Skip to content

[cli] CI check and environment flag override for update#3442

Open
douglowder wants to merge 1 commit intomainfrom
doug/update-environment-override
Open

[cli] CI check and environment flag override for update#3442
douglowder wants to merge 1 commit intomainfrom
doug/update-environment-override

Conversation

@douglowder
Copy link
Contributor

@douglowder douglowder commented Feb 28, 2026

Why

Provide a way to override the new requirement for the --environment flag in eas update.

How

Modify the check to skip when the EAS_UPDATE_SKIP_ENVIRONMENT_CHECK variable is set to a boolish value (1 or true).

Add the CI flag to the tests for whether we should skip the check in a CI environment.

Test Plan

New unit tests added.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@douglowder douglowder marked this pull request as ready for review February 28, 2026 20:21
@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/src/update/** @wschurman, @quinlanj
packages/eas-cli/src/commands/update/** @wschurman, @quinlanj

Generated by CodeMention

@douglowder douglowder force-pushed the doug/update-environment-override branch from 94adb8d to c914a38 Compare February 28, 2026 20:38
@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 52.79%. Comparing base (1d36f4f) to head (c914a38).

Files with missing lines Patch % Lines
packages/eas-cli/src/update/utils.ts 88.89% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3442      +/-   ##
==========================================
+ Coverage   52.78%   52.79%   +0.01%     
==========================================
  Files         809      809              
  Lines       34047    34053       +6     
  Branches     7075     7076       +1     
==========================================
+ Hits        17969    17975       +6     
  Misses      15997    15997              
  Partials       81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@douglowder douglowder requested a review from quinlanj March 2, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant