Skip to content

[worker] Enable COCOAPODS_PARALLEL_CODE_SIGN for iOS builds#3441

Open
sjchmiela wants to merge 1 commit intomainfrom
codex/add-cocoapods_parallel_code_sign-to-env.ts
Open

[worker] Enable COCOAPODS_PARALLEL_CODE_SIGN for iOS builds#3441
sjchmiela wants to merge 1 commit intomainfrom
codex/add-cocoapods_parallel_code_sign-to-env.ts

Conversation

@sjchmiela
Copy link
Contributor

Motivation

  • Enable CocoaPods parallel code signing to speed up iOS builds (notably for projects with dynamic libraries) and keep worker and local build plugin environments consistent.

Description

  • Set COCOAPODS_PARALLEL_CODE_SIGN=true in the worker iOS build environment (packages/worker/src/env.ts) and add the same variable to the local build plugin iOS env construction (packages/local-build-plugin/src/build.ts).

Testing

  • Ran yarn workspace @expo/worker test, which failed in this environment due to missing module resolution for @expo/build-tools in the worker test setup.
  • Ran yarn workspace eas-cli-local-build-plugin test, which succeeded (no tests found, exited 0).

Codex Task

@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.78%. Comparing base (f8deba7) to head (14e3838).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3441   +/-   ##
=======================================
  Coverage   52.78%   52.78%           
=======================================
  Files         809      809           
  Lines       34048    34048           
  Branches     7075     7075           
=======================================
  Hits        17969    17969           
  Misses      15998    15998           
  Partials       81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela changed the title Enable COCOAPODS_PARALLEL_CODE_SIGN for iOS builds [worker] Enable COCOAPODS_PARALLEL_CODE_SIGN for iOS builds Mar 2, 2026
@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Mar 2, 2026
@sjchmiela sjchmiela marked this pull request as ready for review March 2, 2026 10:16
@sjchmiela sjchmiela requested a review from hSATAC March 2, 2026 10:16
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

Copy link
Contributor

@hSATAC hSATAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change is ok but I don’t have enough knowledge to determine if it’s a good idea to enable this globally. I believe it’s default to false for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants