[eas-cli] Enable merge when parsing workflow YAML#3435
Open
[eas-cli] Enable merge when parsing workflow YAML#3435
merge when parsing workflow YAML#3435Conversation
|
Subscribed to pull request
Generated by CodeMention |
sjchmiela
changed the title
merge when parsing YAML
sjchmiela
changed the title
merge when parsing YAMLmerge when parsing workflow YAML
|
✅ Thank you for adding the changelog entry! |
douglowder
approved these changes
Feb 27, 2026
Contributor
douglowder
left a comment
douglowder
left a comment
There was a problem hiding this comment.
Ooh this is beautiful thank you!!!!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3435 +/- ##
==========================================
+ Coverage 52.78% 52.79% +0.01%
==========================================
Files 809 810 +1
Lines 34048 34049 +1
Branches 7075 7075
==========================================
+ Hits 17969 17972 +3
+ Misses 15998 15996 -2
Partials 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://exponent-internal.slack.com/archives/C02VC9BLMQW/p1772224345536829?thread_ts=1763747642.435979&cid=C02VC9BLMQW
I think it'll be nice to add support for aliases and YAML merge. We already "support" it if the user specifies YAML 1.1 preamble.
Test plan
Added unit tests. CI should pass.