Skip to content

Sync spec: v2 app sub-resource routes; drop removed v1 document writes - #93

Merged
longestpath merged 1 commit into
mainfrom
dmosora/sync-spec-v2-app-routes
Sep 9, 2026
Merged

longestpath merged 1 commit into
mainfrom
dmosora/sync-spec-v2-app-routes

Conversation

@longestpath

@longestpath longestpath commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

What

Spec sync from omni@main. A sync PR carries everything since the last sync (v1.2.1, 09-02) — the sections below separate the feature this sync exists for from what rides along. The line count is doubled by the spec being embedded twice (api/openapi.json + cmd/omni/openapi.json, same file).

The feature: v2 app sub-resource routes (alpha)

Five operations added — documents v2-get-app, v2-get-draft-app, v2-get-main-draft-app, v2-put-app, v2-put-app-auto-draft — plus their 8 DocumentsV2App* schemas. The commands generate themselves from the spec (no CLI code), and their --help carries the Alpha note verbatim.

Rides along: endpoints removed from prod (forced the Go changes)

PATCH/PUT /api/v1/documents/{identifier} (documentsUpdate / documentsPut) were removed in exploreomni/omni#62046 — the endpoints are physically gone, so keeping them in the embedded spec would ship commands that 404 everywhere. CLI-side cleanup:

  • the documentsUpdate flags-only shorthand mapping is deleted (the flags-only tier keeps test coverage via modelsGitSync);
  • TestDeprecatedCommand_SchemaEmitsCleanJSON now uses documents transfer-ownership — the one deprecated operation left in the spec (also a PUT, so the method assertion is unchanged).

Rides along: new routes already live on prod

  • DELETE /api/v1/models/{modelId} (modelsDelete, exploreomni/omni#62377)
  • POST /api/v1/ai/jobs/{jobId}/feedback (aiJobFeedbackSubmit, exploreomni/omni#61910)
  • Routine condition additions on the routines CRUD (exploreomni/omni#61487) — 8 new RoutineCondition* schemas

Rides along: wording/schema tweaks on existing operations

~15 operations picked up description or schema-detail changes (permits/boost provisioning exploreomni/omni#62043, routines, dashboards download, eval runs, dbt-sync, content search). No operation changed identity.

Testing

make test green, gofmt clean. Built and spot-checked: the five new app commands generate with the expected positionals/flags and the Alpha help text; documents update/put are gone.

Remaining app routes (PATCH edits, DELETE, create-with-app) are still in review on the omni side and will ride a future sync.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Nen49iqqgJs1XaS27YLZgb

Spec sync from omni@main picks up the new alpha app sub-resource surface
(GET published app, GET/PUT draft app on the main and named drafts) and
the removal of the deprecated v1 document write endpoints
(documentsUpdate / documentsPut).

The removed operations had CLI-side references: the documentsUpdate
flags-only shorthand mapping is deleted (its tier keeps coverage via
modelsGitSync), and the deprecated-command --schema test now uses
documents transfer-ownership, the one deprecated operation left in the
spec.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Nen49iqqgJs1XaS27YLZgb
@longestpath

Copy link
Copy Markdown
Contributor Author

Full disclosure, I asked Claude to update the CLI based on the API merged to main and this is what came out of it. There is a lot of stuff that is not my own work, but it should be derived from the openapi spec, so figured it all should be included to match the actual API.

@Dylan-C-Israel Dylan-C-Israel left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Ran PRT and no blockers or important. I saw no label for it, but after checking if it added it to the PR after being ran apparently that label doesn't exist in CLI repo. Apologies if you ran already.

@longestpath
longestpath merged commit d87cf50 into main Sep 9, 2026
2 checks passed
@longestpath
longestpath deleted the dmosora/sync-spec-v2-app-routes branch September 9, 2026 13:30
@erinkcochran87 erinkcochran87 added the documentation Improvements or additions to documentation label Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants