Skip to content

feat: implement connections pool#23

Open
Kryvchun wants to merge 3 commits into
expected-archives:masterfrom
Kryvchun:feature/pool
Open

feat: implement connections pool#23
Kryvchun wants to merge 3 commits into
expected-archives:masterfrom
Kryvchun:feature/pool

Conversation

@Kryvchun
Copy link
Copy Markdown

@Kryvchun Kryvchun commented Jun 24, 2022

  1. Implement connections pool
  2. Add base tests
  3. Test connection closing

Closes #11
Relates to #14

Changes are not breaking.

@Kryvchun Kryvchun changed the title Support conns pool Implement connections pool Jun 24, 2022
@Kryvchun Kryvchun changed the title Implement connections pool feat: implement connections pool Jun 29, 2022
@Kryvchun
Copy link
Copy Markdown
Author

@remicaumette Can you check it, please?

Comment thread sonic/control.go Outdated
Comment thread sonic/control.go Outdated
@alexisvisco
Copy link
Copy Markdown
Member

Hi, I am looking at it right now, i am sorry for the late reply

@anbraten
Copy link
Copy Markdown

anbraten commented Dec 26, 2022

This should also add thread safety, right? So the readme part about it could be updated?

@hedhyw
Copy link
Copy Markdown

hedhyw commented Dec 26, 2022

This should also add thread safety, right? So the readme part about it could be updated?

Updated

@charandas
Copy link
Copy Markdown

@alexisvisco Is there a plan to getting this merged? It seems the PR author is maintaining the fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bulk functions not work as expected with more than 1 goroutines

6 participants