Moved cljs code into separate files/namespaces.#30
Open
mharris717 wants to merge 1 commit intoexistentialmutt:masterfrom
Open
Moved cljs code into separate files/namespaces.#30mharris717 wants to merge 1 commit intoexistentialmutt:masterfrom
mharris717 wants to merge 1 commit intoexistentialmutt:masterfrom
Conversation
…manually eval user behaviors after starting LT before you can eval ruby code. Not sure why, working on it.
Squashed commit of the following:
commit c275213006411f3b5a46ddc1a6f5d98ddcc95ac0
Author: Mike Harris <mharris717@gmail.com>
Date: Sat Feb 15 14:41:50 2014 -0500
Removed junk
Removed ns requires in main cljs file
Built js properly
When starting LT, u need to eval the user behaviors before things will work. Don't know why.
commit 346c518e201bcd87baa16b0f9008ec0b309e59fd
Author: Mike Harris <mharris717@gmail.com>
Date: Sat Feb 15 14:18:42 2014 -0500
moved config stuff to config ns
commit b580826593f11063b3b368c8c7d3d7ccf5147a0c
Author: Mike Harris <mharris717@gmail.com>
Date: Sat Feb 15 14:13:12 2014 -0500
works better
commit 33e824e75eb8d4196ae81ddc49eff9c5a873a73a
Author: Mike Harris <mharris717@gmail.com>
Date: Sat Feb 15 14:00:49 2014 -0500
evaled something!
commit f07159d143d8612d1398979dd54a36498584bb22
Author: Mike Harris <mharris717@gmail.com>
Date: Sat Feb 15 12:58:18 2014 -0500
CS
commit 44621c233c00f2ac79a3aaef361079dff5469ae9
Author: Mike Harris <mharris717@gmail.com>
Date: Sat Feb 15 11:31:29 2014 -0500
CS
Contributor
Author
|
I'm not completely satisfied with the divisions I chose, but it's a good start. The client namespace is overstuffed. I made an image namespace instead of just deleting it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only hiccup: you need to manually eval user behaviors after starting LT before you can eval ruby code. Not sure why, working on it.
Initially wasn't sure whether to use separate namespaces or not. Decided to give it a try. It's nice to have separate namespaces where everything under the sun isn't required.
Not suggesting this be merged yet, at minimum until the user behavior thing is resolved. Just using the PR as a marker.