Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
@mk-mxp Sorry I faced some sync with previous PR so created a new one. Please provide your feedback. I am happy to work on them |
|
@Narkunan To avoid that kind of trouble, you can follow these steps:
This workflow keeps your local copy as close as possible to the Exercism |
mk-mxp
left a comment
There was a problem hiding this comment.
Thank you for investing the time to sync this! Please take a look at the test data, too, before you submit the next exercise. The differences are everywhere...
mk-mxp
left a comment
There was a problem hiding this comment.
A bit of misunderstanding, I see. The comment block in the students code (Matrix.php) is wanted, the other two (example.php and MatrixTest.php) shall go.
mk-mxp
left a comment
There was a problem hiding this comment.
Thanks a lot for the contribution! Looking forward to the next exercise.
Fix issue #923