Conversation
|
Thank you for your PR, here are some useful tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I do not think testing the dependence in the upstream library is a good practice.
It should be the job from the downstream library.
With exasim-project/NeoFOAM#137 or dependabot, we can easily and frequently update the NeoN version.
If it raises any issue on FoamAdapter, FoamAdapter will notice it on its own repo and need to adapt it. If it is an issue from NeoN, create an issue on NeoN. (Like what to do when Ginkgo has issues in NeoN).
Only fix version not make the complex CI setup between two repo.