Skip to content

Only test NeoN in CI#400

Open
yhmtsai wants to merge 1 commit into
developfrom
clean_ci
Open

Only test NeoN in CI#400
yhmtsai wants to merge 1 commit into
developfrom
clean_ci

Conversation

@yhmtsai
Copy link
Copy Markdown
Collaborator

@yhmtsai yhmtsai commented Nov 7, 2025

Motivation

I do not think testing the dependence in the upstream library is a good practice.
It should be the job from the downstream library.
With exasim-project/NeoFOAM#137 or dependabot, we can easily and frequently update the NeoN version.
If it raises any issue on FoamAdapter, FoamAdapter will notice it on its own repo and need to adapt it. If it is an issue from NeoN, create an issue on NeoN. (Like what to do when Ginkgo has issues in NeoN).
Only fix version not make the complex CI setup between two repo.

@yhmtsai yhmtsai requested review from chihtaw and greole November 7, 2025 14:51
@yhmtsai yhmtsai self-assigned this Nov 7, 2025
@yhmtsai yhmtsai added the ready-for-review Set this label to indicate that the PR is ready for review label Nov 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 7, 2025

Thank you for your PR, here are some useful tips:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Set this label to indicate that the PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant