Add corrected and limitedCorrected snGrad support in NeoFOAM#266
Draft
HendriceH wants to merge 2 commits into
Draft
Add corrected and limitedCorrected snGrad support in NeoFOAM#266HendriceH wants to merge 2 commits into
HendriceH wants to merge 2 commits into
Conversation
|
Deployed test documentation to https://exasim-project.com/NeoFOAM/Build_PR_266 |
- Update NeoN submodule to feat/snGradLimitedCorrected which adds the corrected and limitedCorrected faceNormalGradient schemes - Extend mapFvSchemes() compatibility layer with updateSnGradSchemes() to translate OpenFOAM snGrad scheme names to NeoN names: "limited <coeff>" -> "limitedCorrected <coeff>" in TokenList entries - Add integration test test_snGrad comparing NeoFOAM vs OpenFOAM for uncorrected, corrected, and limitedCorrected schemes on a parallelogram mesh with ~26.6° non-orthogonality so the correction term is non-trivial - Add setup_snGrad/ test setup with a skewed blockMesh
HendriceH
force-pushed
the
feat/snGradLimitedCorrected
branch
from
acfd28a to
9b916d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update NeoN submodule to feat/snGradLimitedCorrected which adds the corrected and limitedCorrected faceNormalGradient schemes
Extend mapFvSchemes() compatibility layer with updateSnGradSchemes() to translate OpenFOAM snGrad scheme names to NeoN names: "limited " -> "limitedCorrected " in TokenList entries
Add integration test test_snGrad comparing NeoFOAM vs OpenFOAM for uncorrected, corrected, and limitedCorrected schemes on a parallelogram mesh with ~26.6° non-orthogonality so the correction term is non-trivial
Add setup_snGrad/ test setup with a skewed blockMesh