Repository navigation
Conversation
Money returns {:error, exception} for Localize errors such as an invalid
locale. Casting a string then returned {:ok, {:error, exception}}, and
casting a map raised CaseClauseError.
Convert both error shapes into Ecto cast errors in one place, and merge the
three identical map clauses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
Problem
Money.Ecto.Map.Typedelegatescast/2, so it has the same bug.After
Details
Money.Ecto.Composite.Type.cast/2matches only{:error, {module, message}}.Money.new/3andMoney.parse/2return{:error, exception}for errors from Localize.cast_result/1and keep the existingexception:andmessage:keyword error.Decimalamount had the same body, so they are now one clause.test/money_ecto_edge_case_test.exs, for both types and for string, string-keyed map, and atom-keyed map input.mix test(179 passed, 5 skipped, PostgreSQL 17) andmix format --check-formattedpass.AI disclosure: AI models helped us find this issue, write the change, and review it.