fix: resolve multiple bugs across codebase#61
Merged
Merged
Conversation
- Fix test conflict: test_sanitizer.py expected 'unnamed' but code returns 'untitled' - Fix test_sanitizer_security path traversal assertions to match actual behavior - Fix sanitizer Unicode loss: replace ASCII-only encoding with NFKC normalization - Add ttl parameter to CacheManager.set() to fix TypeError in aniskip.py - Fix e.response AttributeError in base.py when response is None - Fix config.set() crash in headless mode with in-memory store fallback - Fix cross-filesystem rename in headless_downloader using shutil.move() Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_sanitizer.pyexpected'unnamed'but code returns'untitled'test_sanitizer_securitypath traversal assertions to match actual behaviorttlparameter toCacheManager.set()to fixTypeErrorinaniskip.pye.responseAttributeErrorinbase.pywhen response isNone(ConnectionError/Timeout)config.set()crash in headless mode with in-memory store fallbackheadless_downloaderusingshutil.move()Tests
All 29 related tests pass after these changes.