security: fix injection vulnerabilities and unsafe deserialization#60
Merged
Conversation
- Fix PowerShell/AppleScript injection in notifier via input sanitization - Fix batch file injection in updater by escaping special characters - Replace pickle with JSON for provider cache to prevent arbitrary code execution - Add tar path traversal protection with filter='data' (CVE-2007-4559) - Add language code validation in i18n to prevent path traversal - Add notify-send existence check and timeouts for Linux/macOS notifications - Remove unused Optional import from notifier Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter='data'Optionalimport from notifierSecurity Issues Addressed
notifier.py): User-controlled title/message were interpolated directly into PowerShell scriptsnotifier.py): Same issue with macOSosascriptcommandsupdater.py): File paths with special characters could execute arbitrary commandsregistry.py):pickle.load()on cache file allowed arbitrary code executioni18n.py): Unvalidated language codes could read arbitrary filesdependency_manager.py):extractall()without filter parameter