Diff saved as screenshotDiffs/null, not picked up by upload loop#54
Open
hannesa2 wants to merge 1 commit intoewanmellor:masterfrom
Open
Diff saved as screenshotDiffs/null, not picked up by upload loop#54hannesa2 wants to merge 1 commit intoewanmellor:masterfrom
hannesa2 wants to merge 1 commit intoewanmellor:masterfrom
Conversation
The bug is clear. $name (line 5, the git-relative path) is always the correct source for the filename — it's never /dev/null. The if/else logic is wrong in both directions: When name1=/dev/null (new file): basename "/dev/null" → "null" ❌ When name2=/dev/null (deleted file): basename "/dev/null" → also "null" ❌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug is clear. $name (line 5, the git-relative path) is always the correct source for the filename — it's never
/dev/nullThe if/else logic is wrong in both directions: