Repository navigation
Add production change confirmation for flags and values - #78
Merged
Merged
Conversation
added 2 commits
July 31, 2026 17:45
Adds the openspec CLI's Claude Code integration (opsx/* slash commands, openspec-* skills) and repo config, so spec-driven changes can be authored and reviewed the same way going forward.
PR #77 added a prod-change confirmation but hardcoded the hostname and message in Flag.jsx and used window.confirm(), so it couldn't be configured per-environment and never covered Value.jsx. Replace it with a server-configured ui.confirmation_required flag (YAML), exposed via GraphQL as confirmationRequired and consumed by a shared ConfirmableButton (antd Popconfirm) wired into Apply, Reset, and Delete on both Flag.jsx and Value.jsx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.confirmapproach with a server-configuredui.confirmation_requiredflag (YAML), exposed via GraphQL asconfirmationRequired.ConfirmableButton(antdPopconfirm) and wires it into Apply, Reset, and Delete on bothFlag.jsxandValue.jsx— PR add prod confirmation popup #77 only coveredFlag.jsx.confirmation_requiredisfalse(default), behavior is unchanged: Apply/Reset fire immediately, Delete keeps its existing generic confirmation copy.true: Apply/Reset now require confirmation (previously none), and Delete's confirmation title becomes "This changes production".opsx/*slash commands,openspec-*skills) as its first real usage — seeopenspec/changes/confirmation-required/for the full proposal/design/spec.Test plan
lets test— 146/146 backend tests pass, including a newtest_confirmation_required_defaultGraphQL testnpm run build— cleanPopconfirmand only mutate after confirming