Repository navigation
fix(cli): accept evlog 2.31 as a peer so the CLI installs on 2.x projects - #920
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Thank you for following the naming conventions! 🙏 |
@evlog/cli
evlog
@evlog/nuxthub
@evlog/signals
@evlog/telemetry
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs EVL-705. The
evlog upgradeacceptance criterion stays open until #870 lands onv3, so this PR does not close the issue on merge.What changed
packages/cli/package.json: theevlogpeer goes from>=3.0.0-beta.0to^2.31.0 || >=3.0.0-beta.0. The peer stays required, since it was never optional.@evlog/cli.Testjob,CLI installs next to evlog 2.x, that packs the CLI and installs it into a fresh npm project onevlog@2.31.0andevlog@2.33.1with no--legacy-peer-deps, then runsevlog doctor --json. It runs only whenpackages/clichanges on a pull request.Why 2.31.0 is the minimum
The CLI changelog (0.10.0) already says the CLI needs evlog 2.31.0 or later, and
mainhas carried that peer since then. I checked the commands that do not need a framework against 2.31.0 and 2.33.1:--version,doctor,config.mapexits 1 on a bare fixture because no framework is detected, which is the expected result, not a load failure. Lower 2.x versions are not tested, so the range does not claim them.Before and after
Before (unmodified peer range, npm 11,
evlog@2.33.1already installed):After (packed CLI from this branch, same project shape):
The same four steps pass on
evlog@2.33.1, with npm and with pnpm. pnpm also passes withstrict-peer-dependencies=true.Verification
doctoron 2.31.0 and 2.33.1, npm and pnpm; pnpm strict on 2.31.0;pnpm run lint,pnpm run typecheck, andpnpm run testinpackages/cli(34 files, 707 tests). Node 24.21.0 in the sandbox.2662c99, the CI step alone. It fails on the old range with theERESOLVEabove, thencca25e8widens the range.Not verified here
evlog upgradeon a 2.x fixture is not covered. Theupgradecommand is not onv3yet; it lands with feat(cli): scaffold evlog upgrade with the v2 to v3 transform table #870. Once it does, the CI step should also runevlog upgrade --dry-runon the 2.x fixture..changeset/config.jsonalready setsonlyUpdatePeerDependentsWhenOutOfRange: true, and^2.31.0 || >=3.0.0-beta.0already contains3.0.0-beta.0, so changesets should leave it alone. I have not runchangeset versionto prove it. chore(repo): version packages (beta) #878 needs a check after it regenerates.@evlog/telemetryEBADENGINEwarning on Node 20 from the earlier report. The CLI'senginesfield is>=22, so this PR does not touch it.ELI5
The command-line helper for evlog only let itself be installed next to evlog 3 betas. Projects still on evlog 2 got an install error. This change lets the helper sit next to evlog 2.31 and later, and a new automated check installs it next to two versions of evlog 2 to make sure that keeps working.