Fix Linux PyInstaller onedir spec for AppImage builds - #2
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Build Linux (AppImage)
Fix Linux PyInstaller onedir spec for AppImage builds
Jul 25, 2026
evildevill
marked this pull request as ready for review
July 25, 2026 08:39
There was a problem hiding this comment.
Pull request overview
Fixes the Linux PyInstaller onedir spec used for AppImage builds by eliminating a dist/PlaylistForge path collision (file vs directory) and adds a regression test to prevent reintroducing the issue.
Changes:
- Update
playlistforge.linux.specto use the standard onedir pattern (exclude_binaries=True) and move binaries/datas collection toCOLLECT(...). - Add a packaging-spec regression test that parses the Linux spec and asserts
exclude_binaries=Trueon theEXE(...)call.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packaging/pyinstaller/playlistforge.linux.spec | Switches Linux PyInstaller output to proper onedir layout by excluding binaries from EXE and collecting them in COLLECT. |
| tests/test_packaging_specs.py | Adds a focused AST-based regression test to ensure exclude_binaries=True remains set in the Linux spec. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux AppImage workflow was failing before packaging because the PyInstaller Linux spec emitted the executable and collected bundle to the same
dist/PlaylistForgepath. This change removes that path collision so the AppImage job can produce the onedir bundle expected by the workflow.PyInstaller Linux spec
exclude_binaries=TrueonEXE(...)COLLECT(...), avoiding thedist/PlaylistForgefile-vs-directory conflict that broke the CI jobRegression coverage
playlistforge.linux.specand asserts the Linux build keepsexclude_binaries=True