Conversation
Add `atosl crash <REPORT>` for symbolicating entire Apple crash reports: modern .ips (JSON) and legacy .crash (text). Each referenced image is matched against --dsym-dir directories by UUID/build-id (indexed once), resolved through the existing engine, and the report is rewritten in place with symbolicated frames. Images without a match are left as-is. The `crash` token is routed before the default address parser so the report path never collides with positional addresses. https://claude.ai/code/session_01XAne4ituXPChWeo9TjA3z7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
crashsubcommand that symbolicates an entire Apple crash report and rewrites it in place:.ips(JSON metadata line + JSON body withusedImages/threads) and legacy.crash(textBinary Images:table + thread frames). Format is auto-detected.--dsym-dirdirectories by Mach-O UUID or ELF build-id. The directories are indexed once, then each image's frames are symbolized in a single pass through the existing engine (so dSYM/debuglink/fat-slice handling all apply)..ipsframes gainsymbol/symbolLocation/sourceFile/sourceLine;.crashframe lines get their trailing detail replaced withsymbol (file:line)(orsymbol + offset). Images without a matching dSYM are left untouched, so partial symbol sets still yield a usable report.--output <FILE>.Usage:
Implementation notes
src/crash.rsmodule; reuseswith_symbolizer, the directory UUID/build-id index, andnormalize_hex_id(nowpub(crate)).crashtoken is routed to its own parser before the default address parser, so the report path never competes with the top-level positionaladdresses(clap can't disambiguate a bare positional from a subcommand). The flatatosl -o ... -l ... <addr>interface is unchanged.--dsym-dirdirectories (and the existing debuginfod cache via the engine).Test plan
cargo fmt,cargo clippy --all-targets -- -D warnings,cargo test(all green locally).crashtext and.ipsJSON paths end-to-endNote: real-world Apple
.ips/.crashfiles reference Mach-O images, which can only be exercised end-to-end on macOS; the Linux CI tests cover the parsers and the full orchestration via build-id-matched ELF fixtures.https://claude.ai/code/session_01XAne4ituXPChWeo9TjA3z7
Generated by Claude Code