Merged
Conversation
oskardudycz
added
enhancement
…ction levels to Dumbo
oskardudycz
force-pushed
the
readonly_transactions
branch
from
1692292 to
d07c5a8
Compare
oskardudycz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added also (naive sudo, but still) options to specify whether the connection is read-only. (This will be expanded later on.
Note: Currently, tests are super naive as they just check if the transaction didn't fail. I won't be testing transaction levels, but I'll need to add SQL tracker to check what's sent to the client. Still, I wasn't great at small PRs recently, so let's keep it out of scope for this one.