Repository navigation
Refuse a release while another version is with App Review - #142
Merged
Merged
Conversation
evandhoffman
added
the
skip-release
evandhoffman
enabled auto-merge
October 13, 2026 00:27
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-appstore.ymlpassed a dry run of 2.6.0 while version 2.5.5 was IN_REVIEW. The script looked only at the review submissions. The 2.5.5 submission is already COMPLETE, so the script saw no open review.The script now also reads the state of every other App Store version. It refuses, in each mode, when another version is with App Review or approved and not yet live: WAITING_FOR_EXPORT_COMPLIANCE, WAITING_FOR_REVIEW, IN_REVIEW, PENDING_DEVELOPER_RELEASE, PENDING_APPLE_RELEASE, ACCEPTED or PROCESSING_FOR_DISTRIBUTION. The refusal names the version and its state.
The plan line for a new version now says "What's New: from the changelog, for the new version". Since #141, a new version always takes the changelog text.
Verification
uv run ruff format --check . && uv run ruff check . && uv run mypy && uv run pytest -rs: 333 passed, 0 skipped. The new test covers three states in each of the three modes, and checks that nothing is written.Release
skip-release: scripts and docs only.