Repository navigation
Automate the App Store submission - #139
Merged
Merged
Conversation
…rom secrets A failed submit run can leave the version READY_FOR_REVIEW in a draft submission. The script now reuses that version and the draft, so the next run can finish. The review detail write sends only the contact values from the secrets, so an API error cannot repeat a kept value, and the write is skipped when nothing changes. A rejected submission (UNRESOLVED_ISSUES) now asks for an answer in App Store Connect. The runbook covers both cases.
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR automates the App Store submission. It does items 2 and 3 of #132.
release-appstore.yml: dispatch only, on the Linux runner.version,build(optional),mode,release_typeandreplace_whats_new.modeisdry-run(the default, writes nothing),prepare(writes, does not submit) orsubmit.env:, and the shell checks it. The API key is deleted even when the job fails.scripts/submit_appstore_release.py: ported from StationCast, with 110 new tests. It usesscripts/asc_api.py, not its own JWT code.docs/changelog.md.ASC_REVIEW_CONTACT_*. A set secret wins over the value in App Store Connect. The script never logs a contact value: a test checks every log record, and API errors are redacted.scripts/changelog.py checknow refuses<and>. App Store Connect refused them in What's New today ("must not contain markup language"). One old changelog line is reworded.docs/app-store-release.md: the runbook. It covers the key and the secrets, a public release, external TestFlight, the checks after a submission, a failed run, a rejection and the key rotation.ios-tests.ymltreatsrelease-appstore.ymlas Linux-only.AGENTS.mdis updated.Verification
actionlint: no findings.mypy --strictandpytest -rs: 319 passed, 0 skipped.scripts/changelog.py check: passes.pre-commit run --all-files: all hooks pass.Before the first prepare or submit run
The owner sets the four
ASC_REVIEW_CONTACT_*secrets (see the runbook).Release
skip-release. CI, tooling and docs only.