Skip to content

Fix/dashboard followups - #197

Open
atulmgupta wants to merge 1581 commits into
mainfrom
fix/dashboard-followups
Open

atulmgupta wants to merge 1581 commits into
mainfrom
fix/dashboard-followups

Conversation

@atulmgupta

Copy link
Copy Markdown
Collaborator

Description

Closes #

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would break existing functionality)
  • Documentation update
  • Infrastructure / CI change

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or my feature works
  • New and existing tests pass locally
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Screenshots (if applicable)

Copilot AI balanced review requested due to automatic review settings October 7, 2026 00:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

const { client } = mount();
const table = await screen.findByRole('table', { name: 'Drain sessions' });
for (const name of ['Started', 'Duration', 'Start %', 'End %', 'Loss %', 'Rate %/day', 'Ambient']) {
expect(within(table).getByRole('columnheader', { name: new RegExp(name.replace('%', '%')) })).toBeInTheDocument();
'SoC drift', 'Already-full dwell (min)', 'Pairing signals', 'Charge ID', 'Drive ID',
];
for (const header of expected) {
expect(within(table).getByRole('columnheader', { name: new RegExp(header.replace(/[()]/g, '\\$&')) })).toBeInTheDocument();
const { client } = mount();
const table = await screen.findByRole('table', { name: 'Drain sessions' });
for (const name of ['Started', 'Duration', 'Start %', 'End %', 'Loss %', 'Rate %/day', 'Ambient']) {
expect(within(table).getByRole('columnheader', { name: new RegExp(name.replace('%', '%')) })).toBeInTheDocument();

Copilot AI commented Oct 7, 2026

Copy link
Copy Markdown

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Verify TypeScript build

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

@atulmgupta atulmgupta self-assigned this Oct 7, 2026
Copilot AI balanced review requested due to automatic review settings October 7, 2026 06:51
@github-actions github-actions Bot added the ci label Oct 7, 2026

Copilot AI commented Oct 7, 2026

Copy link
Copy Markdown

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Verify TypeScript build

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Critical telemetry incompatibilities and unresolved table, notification, and prefetch regressions block approval.

Review effort: Balanced
Findings: None

atulmgupta and others added 15 commits October 12, 2026 21:43
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 499cebd4-378c-418c-9113-3b8fe85355b5
atulmgupta and others added 30 commits October 13, 2026 17:59
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve the released four-file caller changes and 32 authored contracts. Runtime discovery was zero due to external catalog startup; scoped compiler not run. Retain attempt one and exact remaining catalog/proof needs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve 114 existing passes and 10 additional passes as 124 unique covered cases, not a full rerun. Production client and resilience sources remain byte-identical. Record compiler cadence, actual actor IDs and accurate caller/catalog debt.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add 31 canonical leaves and intentionally replace two obsolete lookup descriptions. Preserve every other old leaf; normal generator, check and strict namespace audit passed. Runtime manifest and baselines remain unchanged. Caller runtime and native acceptance remain separate.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Accept actual 27-case scoped lifecycle proof after normal catalog recovery. Preserve oldest-first timeline, expiry clock, preferences and all real manifest timestamps. Keep original obsolete job-state fixtures and native acceptance explicitly separate.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Persist released exact source and 14 authored cases. Normal covering proof executed 13 passing cases and one incorrect zero-argument click oracle; keep that real failure pending before fixture-only retry. Exact canonical copy is already integrated.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Persist released canonical manifest source and its covering fixture. Normal proof executed 36 passing cases and one activation test with an invalid zero-global-timer oracle. Preserve all outcomes and keep that specific correction pending; no native or durable-audit claim.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Forward genuine refreshing state and only classify explicit unsupported-subsystem 503s as configuration gaps. Preserve three independent panels and derived trust. Exact four pins verified; 17 unique cases passed across initial 16 and one corrected-case run, with historical failure retained.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Accept 23 actually executed passing cases with both current pins verified. Shipping formatter unchanged; preserve all 16 original expanded cases plus seven additive boundary, DST, locale, timezone and epoch-zero cases.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Accept exact 24 passing cases and original 20-case byte preservation. Shipping component unchanged; additive tests prove independent healthy zero, fatal recovery and retained object or array empty state and retry behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Accept exact 26 passing cases and matched source/fixture pins. Preserve real zero rows and all metrics; disclose observed invalid/returned/unique coverage without treating absent data as authoritative empty. Native and unavailable original immutable baseline remain unverified.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Correct fixture motion identity and establish real initial tab focus. The failed-only case now passes, with 31 prior valid cases retained for 32 unique coverage; not a fresh full rerun. Production, shared focus helpers and original fixtures unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve and strengthen native-link, canceled-click and focus guarantees; compare activation timers against the jsdom focus baseline. One corrected case passed, plus 36 retained passes gives 37 unique coverage, not a fresh full rerun.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
React click legitimately supplies an event to the void callback. Assert once and unchanged raw ID while preserving exact Enter arguments. One failed-only correction passed, with 13 retained passes, not a fresh 14-case rerun.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve producer hits:null and genuine empty while rejecting absent/malformed roots without fabricated authoritative zero. Actual 36 cases pass; production ES2020 and fixture ES2022 scoped own typing pass. Original ES2020 fixture library mismatch and concurrent external page pin drift remain recorded. Parent source-only progress and actual refill claims included.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve all fourteen original scenario names via explicit wire-manifest crosswalk rather than fabricated job states. Actual normal fourteen cases pass with native-link cancellation and causal timer/focus checks. Scoped types/lint/scans/preservation pass; no production or new contract changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Persist exact released six-file source/contract work before a corrective lease. Normal parent execution is 36 executed, 35 passed and one real-query recovery assertion failure, not green or external. Existing query prop capability is available for callers; diagnosis/correction is still required. No native/application acceptance.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Persist exact released four-file work with 32 cumulative ultimately passing cases, not fresh full32. Before/after compression is not additive storage composition and absent estimates do not prove no quota. Parent found tightly coupled new cold-paused branches using false deployment-disabled default body; source correction and 14 exact canonical replacements still required. No source/native acceptance.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants