Skip to content

test: pin no-default reader on services.workflows.list_runs (#2533 follow-up) - #2544

Merged
eumemic merged 2 commits into
masterfrom
dev-pipeline/issue-2537
Oct 12, 2026
Merged

eumemic merged 2 commits into
masterfrom
dev-pipeline/issue-2537

Conversation

@eumemic

@eumemic eumemic commented Oct 12, 2026

Copy link
Copy Markdown
Owner

Automated dev-pipeline build for issue #2537.

@eumemic eumemic added the pipeline:v2 Owned by the dev-pipeline RECONCILER (not the v1 monolith). Reconciler ONLY touches v2 items. label Oct 12, 2026
@eumemic-bot

eumemic-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Code review

No actionable correctness, security, or regression findings. The PR adds regression coverage for the already-enforced required reader parameter on services.workflows.list_runs.

The focused test could not be executed because pytest is not installed in the environment.

uv 0.13.0 (2026-10-09) made Python 3.15 the default; the migration-head job
ran unpinned `uv run`, which provisioned cp315 and failed (exit 2) resolving
psycopg-binary 3.3.3 (wheels only for cp313/cp314) before the check ran.
Reproduced locally with UV_PYTHON_PREFERENCE=only-managed (rc=2), and green
with Python 3.13 pinned (rc=0, one head: 0194).
@eumemic-bot

eumemic-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Code review

No actionable correctness, security, or regression findings.

Focused test execution was unavailable because uv is not installed in the environment.

@eumemic

eumemic commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

Code review

Canonical review record (reconciler-written, company#383)

Verdict: MERGE-SAFE at 2dfe8e60cf3e08a4d732f8b1d8141be320d12e1c.

No blocking findings at this head.

Canonical record written by the reconciler from the reviewer's structured return (company#383); the reviewer's own prose comment is discussion.

@eumemic

eumemic commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

Risk Assessment

Tier 4

Tier 2. The PR changes 2 files, adding 28 lines and removing none. It adds one unit test that checks services.workflows.list_runs fails when no reader is passed, before it touches the DB (#2537). It also changes the migration-head-check CI workflow to pin Python 3.13 in setup-uv, because Python 3.15 has no psycopg-binary wheels. No production code changes. The CI change is small but affects the migration safety check, so I'm rating it 2 rather than 1.

Risk floored to tier 4 (privileged surface / files-fetch failure — #1185/#1187).

@eumemic
eumemic merged commit b97391f into master Oct 12, 2026
11 checks passed
@eumemic
eumemic deleted the dev-pipeline/issue-2537 branch October 12, 2026 14:52
@eumemic

eumemic commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

Auto-merge receipt

The dev-pipeline reconciler auto-merged PR #2544 at head 2dfe8e60cf3e08a4d732f8b1d8141be320d12e1c after proving: risk tier 4 (cap 4), reviewed-green provenance for this head, the complete required check set green, no hold/fix/human veto, and behind_by=0 against master.

@eumemic

eumemic commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

Post-merge: a pipeline PR was merged WITHOUT the maker≠checker gate

pipeline:v2 PR #2544 MERGED without the reconciler's maker≠checker gate (risk:tier-4 is ABOVE the auto-merge cap (2)). Auto-merge requires reviewed:green + an in-cap risk tier — this merge bypassed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge:approved pipeline:v2 Owned by the dev-pipeline RECONCILER (not the v1 monolith). Reconciler ONLY touches v2 items. reviewed:green@2dfe8e60cf3e risk:tier-4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant