Repository navigation
fix(editor): cherry-pick Windows Ctrl+Q freeze fix for v1.12.1 - #1596
Merged
Merged
Conversation
* fix(editor): error on Ctrl+Q exit on Windows * fix: lint error * fix: coderabbit comments * fix(term): discard reads interrupted by Drain when the tty restarts A read in flight when Drain runs completes with the previous session's interruption. After Stop and Start, the next Read consumed that stale result and returned its error, which ends tcell's input loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: eugenioenko <eugenioenko@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 576a865)
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks #1592 onto
v1.12.0for a v1.12.1 patch release, so Windows users get the fix for #1586 without the features merged to main since v1.12.0 (#1488, #1552).release/v1.12.xwas created at thev1.12.0tag (b006662). After merging, tag the merge commitv1.12.1.Why
v1.12.0 freezes on every Ctrl+Q on Windows. After tcell drains input at shutdown, the Windows console reader returns
(0, nil)on every read. The OSC reader added in #1500 retried those empty reads forever, so tcell's input loop never exited andFinihung.Tests
git cherry-pick -x 576a865f).go test ./internal/term ./internal/app ./cmd/...passes.Closes #1586.
🤖 Generated with Claude Code