Skip to content

fix(editor): cherry-pick Windows Ctrl+Q freeze fix for v1.12.1 - #1596

Merged
eugenioenko merged 1 commit into
release/v1.12.xfrom
hotfix/v1.12.1-windows-quit
Nov 13, 2026
Merged

eugenioenko merged 1 commit into
release/v1.12.xfrom
hotfix/v1.12.1-windows-quit

Conversation

@eugenioenko

Copy link
Copy Markdown
Owner

Cherry-picks #1592 onto v1.12.0 for a v1.12.1 patch release, so Windows users get the fix for #1586 without the features merged to main since v1.12.0 (#1488, #1552).

release/v1.12.x was created at the v1.12.0 tag (b006662). After merging, tag the merge commit v1.12.1.

Why

v1.12.0 freezes on every Ctrl+Q on Windows. After tcell drains input at shutdown, the Windows console reader returns (0, nil) on every read. The OSC reader added in #1500 retried those empty reads forever, so tcell's input loop never exited and Fini hung.

Tests

  • The cherry-pick applies cleanly (git cherry-pick -x 576a865f).
  • go test ./internal/term ./internal/app ./cmd/... passes.
  • Windows build checked under wine with a real Ctrl+Q through the tty: v1.12.0 hangs after the force quit, and this branch exits with code 0.

Closes #1586.

🤖 Generated with Claude Code

* fix(editor): error on Ctrl+Q exit on Windows

* fix: lint error

* fix: coderabbit comments

* fix(term): discard reads interrupted by Drain when the tty restarts

A read in flight when Drain runs completes with the previous session's
interruption. After Stop and Start, the next Read consumed that stale
result and returned its error, which ends tcell's input loop.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: eugenioenko <eugenioenko@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 576a865)
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@eugenioenko
eugenioenko merged commit 19facca into release/v1.12.x Nov 13, 2026
1 check passed
@eugenioenko
eugenioenko deleted the hotfix/v1.12.1-windows-quit branch November 13, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants