Conversation
erosselli
force-pushed
the
LJ-421-bump-validators
branch
from
82f0c99 to
f9fc853
Compare
erosselli
commented
Mar 6, 2025
Comment on lines
+52
to
+60
| lint: | ||
| @echo "Running all static checks..." | ||
| @$(RUN_NO_DEPS) black --exclude="sdk/python/_version\.py" fideslog/ tests/ | ||
| @$(RUN_NO_DEPS) isort fideslog/ tests/ | ||
| @$(RUN_NO_DEPS) mypy | ||
| @$(RUN_NO_DEPS) pylint fideslog/ | ||
| @$(RUN_NO_DEPS) xenon fideslog --max-absolute B --max-modules B --max-average A --ignore "tests" --exclude "fideslog/sdk/python/_version.py" | ||
| @echo "Completed all static checks!" | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
there was no command to run formatters all together, and the ones to run black / isort individually are used for CI and have the --check flag so they don't actually format the files , so I added this command
Collaborator
There was a problem hiding this comment.
leaving the world (fideslog) a better place than you found it!
adamsachs
approved these changes
Mar 6, 2025
Collaborator
adamsachs
left a comment
adamsachs
left a comment
There was a problem hiding this comment.
nice, thanks for taking the time to do this and unblock other things 👍
Comment on lines
+52
to
+60
| lint: | ||
| @echo "Running all static checks..." | ||
| @$(RUN_NO_DEPS) black --exclude="sdk/python/_version\.py" fideslog/ tests/ | ||
| @$(RUN_NO_DEPS) isort fideslog/ tests/ | ||
| @$(RUN_NO_DEPS) mypy | ||
| @$(RUN_NO_DEPS) pylint fideslog/ | ||
| @$(RUN_NO_DEPS) xenon fideslog --max-absolute B --max-modules B --max-average A --ignore "tests" --exclude "fideslog/sdk/python/_version.py" | ||
| @echo "Completed all static checks!" | ||
|
|
Collaborator
There was a problem hiding this comment.
leaving the world (fideslog) a better place than you found it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
validatorsversion to 0.43 and adds a test for the URL validation it performs.I also had to update our github action yaml because we were using a deprecated action that no longer runs.
Testing
To test the change, I ran the api server locally and made sure the
POST /eventendpoint still worked. Tested with a valid URL and an invalid URL in theendpointfield of the payload.I also added a unit test for this.