ENG-2539: Add jira_ticket connection type with singleton enforcement#7388
ENG-2539: Add jira_ticket connection type with singleton enforcement#7388eastandwestwind wants to merge 5 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile OverviewGreptile SummaryAdds Changes:
Issues found:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 416eb61 |
Additional Comments (2)
The Union type is used for API documentation. All other connection types include their DocsSchema variant here.
The Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
… jira_ticket connections Co-authored-by: Cursor <cursoragent@cursor.com>
594d79c to
b35622b
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
https://ethyca.atlassian.net/browse/ENG-2539
jira_ticketto theConnectionTypeenum with human-readable name and system type mappingsjira_ticketto theManualTaskTypeenumJiraTicketSchemasecrets schema for OAuth token storage (populated by OAuth callback flow)secrets_schemasmappingjira_ticketconnection allowed per deploymentconnectiontypePostgreSQL typeCode Changes
src/fides/api/models/connectionconfig.py— Addedjira_ticketenum value +human_readableandsystem_typemappingssrc/fides/api/models/manual_task/manual_task.py— Addedjira_tickettoManualTaskTypesrc/fides/api/schemas/connection_configuration/connection_secrets_jira_ticket.py(new) —JiraTicketSchemawith optional OAuth fieldssrc/fides/api/schemas/connection_configuration/__init__.py— Import and registerJiraTicketSchemasrc/fides/service/connection/connection_service.py— Singleton enforcement via_singleton_connection_typessetsrc/fides/api/alembic/migrations/versions/xx_2026_02_13_..._add_jira_ticket_to_connectiontype.py(new) — Alembic migrationtests/service/test_jira_ticket_connection.py(new) — Tests for enum, schema, and singletonchangelog/ENG-2539-jira-ticket-connection-type.yaml(new) — Changelog entrySteps to Confirm
jira_ticketconnection can be created via the existing PATCH /connection endpointJiraTicketSchemajira_ticketconnection raises aValidationErrorjira_ticketconnection still workstests/service/test_jira_ticket_connection.pyMade with Cursor