Skip to content

Fix case insensitive connector type matching#7386

Open
Linker44 wants to merge 3 commits intomainfrom
fix-case-insensitive-connector-type-matching
Open

Fix case insensitive connector type matching#7386
Linker44 wants to merge 3 commits intomainfrom
fix-case-insensitive-connector-type-matching

Conversation

@Linker44
Copy link
Contributor

Ticket []

Description Of Changes

Code Changes

Steps to Confirm

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@Linker44 Linker44 requested a review from tvandort February 13, 2026 01:18
@Linker44 Linker44 self-assigned this Feb 13, 2026
@Linker44 Linker44 requested a review from a team as a code owner February 13, 2026 01:18
@Linker44 Linker44 requested review from JadeCara and removed request for a team February 13, 2026 01:18
@vercel
Copy link
Contributor

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Feb 13, 2026 1:25am
fides-privacy-center Ignored Ignored Feb 13, 2026 1:25am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 13, 2026

Greptile Overview

Greptile Summary

Fixed a bug where connector type matching failed when the stored type field in saas_config had different casing than the connector template. The fix adds case-insensitive comparison using sa_func.lower() on both sides of the filter condition, ensuring that connector configs are properly updated regardless of case differences.

  • Changed the database filter to use sa_func.lower() for case-insensitive comparison
  • Added import for sqlalchemy func as sa_func
  • Added logging to track how many connection configs were found for the connector type
  • Changed return type annotation from Iterable[ConnectionConfig] to list[ConnectionConfig] for clarity
  • Added comprehensive test case that validates uppercase stored types match lowercase template types
  • Test includes manual cleanup that should be removed per project guidelines

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is straightforward, well-tested, and addresses a specific bug. The case-insensitive comparison is the correct approach for this issue. The only concern is a minor style violation with manual test cleanup that doesn't affect production code.
  • No files require special attention

Important Files Changed

Filename Overview
src/fides/service/connection/connection_service.py Added case-insensitive matching for connector types using sa_func.lower() and added helpful logging
tests/service/test_connection_service.py Comprehensive test for case-insensitive connector type matching; includes unnecessary manual cleanup

Last reviewed commit: 8f035bc

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@Linker44 Linker44 removed the request for review from JadeCara February 13, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant