Skip to content

ENG-2505 Update policy keys in notice sandbox#7378

Open
erosselli wants to merge 3 commits intomainfrom
erosselli/ENG-2505-privacy-notice-sandbox
Open

ENG-2505 Update policy keys in notice sandbox#7378
erosselli wants to merge 3 commits intomainfrom
erosselli/ENG-2505-privacy-notice-sandbox

Conversation

@erosselli
Copy link
Contributor

@erosselli erosselli commented Feb 12, 2026

Ticket ENG-2505

Description Of Changes

In ENG-2505, we renamed the cascade_down_all_cascade_up_optin policy to cascade_down_all_cascade_up_opt_in_all_opt_out_conservative . This PR updates the privacy notice sandbox to use the new keys.

Steps to Confirm

  1. Checkout the backend branch https://github.com/ethyca/fidesplus/pull/3093
  2. Set up an experience with notices
  3. Go to the notice sandbox and submit preferences for cascade_down_all_cascade_up_optin_all_optout_conservative

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@erosselli erosselli requested a review from a team as a code owner February 12, 2026 18:12
@erosselli erosselli requested review from gilluminate and removed request for a team February 12, 2026 18:12
@vercel
Copy link
Contributor

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 13, 2026 2:27pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 13, 2026 2:27pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 12, 2026

Greptile Overview

Greptile Summary

This PR updates the propagation policy key naming in the privacy notices sandbox to align with backend changes. The cascade_down_all_cascade_up_opt_in policy has been renamed to cascade_down_all_cascade_up_optin_all_optout_conservative to better reflect its behavior.

Changes made:

  • Renamed enum key from CASCADE_DOWN_ALL_CASCADE_UP_OPT_IN to CASCADE_DOWN_ALL_CASCADE_UP_OPT_IN_ALL_OPT_OUT_CONSERVATIVE in PropagationPolicyKey.ts
  • Updated string value to cascade_down_all_cascade_up_optin_all_optout_conservative
  • Updated dropdown label in sandbox component to clarify the policy includes opt-out conservative handling

The changes are straightforward and properly synchronized between the enum definition and its usage in the dropdown component. All references to the old key have been updated.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • This is a simple renaming change that updates a policy key to match backend changes. The changes are limited to 2 files, all references have been properly updated, and the modifications are straightforward enum/constant updates with no logic changes
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/types/api/models/PropagationPolicyKey.ts Updated enum key from CASCADE_DOWN_ALL_CASCADE_UP_OPT_IN to CASCADE_DOWN_ALL_CASCADE_UP_OPT_IN_ALL_OPT_OUT_CONSERVATIVE with corresponding string value change to match backend policy rename
clients/admin-ui/src/features/poc/privacy-notices-sandbox/components/PropagationPolicyDropdown.tsx Updated dropdown option to use new enum key and improved label to better describe the policy behavior including opt-out conservative handling

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants