Add vendor logos to Okta monitor results by jpople · Pull Request #7354 · ethyca/fides

jpople · 2026-02-11T00:11:46Z

Ticket ENG-2391

Description Of Changes

Adds vendor logos to Okta monitor results UI.

Code Changes

Updates getDomain helper method to fail usefully (not all results from Okta monitors have logo URLs)

Steps to Confirm

Create an Okta monitor and run the scan.
View the results screen; should see vendor logos displayed where applicable.

Pre-Merge Checklist

vercel · 2026-02-11T00:11:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
fides-plus-nightly	Ready	Preview, Comment	Feb 11, 2026 0:24am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
fides-privacy-center	Ignored		Feb 11, 2026 0:24am

jpople · 2026-02-11T00:14:27Z

...tures/data-discovery-and-detection/action-center/components/InfrastructureSystemListItem.tsx

-            /> */}
+            <Flex className="ml-2">
+              {logoUrl && (
+                <Image


Using an Image here in lieu of an Avatar so oversize images are scaled down and not cropped.

consider adding this as a comment in the code

greptile-apps · 2026-02-11T00:15:53Z

Greptile Overview

Greptile Summary

This PR adds vendor logo support to the Okta monitor results UI by deriving a logo URL from staged resource metadata (metadata.vendor_logo_url) and falling back to a Brandfetch icon URL derived from vendor_id/name. It also hardens getDomain by validating parsed hostnames and updates an existing website-logo resolver to catch getDomain errors and return undefined.

The main integration point is InfrastructureSystemListItem, which now attempts to render a vendor logo next to each result item; other existing UI (e.g. connection logos) continues to use the shared getDomain/getBrandIconUrl helpers.

Confidence Score: 3/5

This PR is close to mergeable but needs a UI fallback fix for failed logo image loads.
Core changes are small and mostly guarded (ConnectionTypeLogo now catches getDomain errors), but InfrastructureSystemListItem renders external images without handling load failures, which will reliably result in broken images for invalid/unreachable logo URLs.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/components/InfrastructureSystemListItem.tsx

Important Files Changed

Filename	Overview
changelog/7354-okta-vendor-logos.yaml	Adds a changelog fragment for Okta monitor vendor logos; no functional issues found.
clients/admin-ui/src/features/common/utils.ts	Updates getDomain to validate and throw on invalid domains; behavior change may throw at call sites (some already wrapped), and prior review threads cover signature/regex concerns.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/components/InfrastructureSystemListItem.tsx	Adds vendor logo rendering for Okta monitor results; currently uses AntD Image without onError fallback, so broken images will display when remote logo URLs fail.
clients/admin-ui/src/features/datastore-connections/ConnectionTypeLogo.tsx	Wraps getDomain usage in try/catch when building website logo URLs, preventing runtime exceptions; change looks safe.

greptile-apps

_{2 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

clients/admin-ui/src/features/common/utils.ts

greptile-apps · 2026-02-11T00:16:03Z

Additional Comments (1)

clients/admin-ui/src/features/datastore-connections/ConnectionTypeLogo.tsx
getDomain now throws errors (changed in this PR), but no try-catch here. Will crash on invalid URLs.

      try {
        const domain = getDomain(data.websiteUrl);
        const retinaSize = (size ?? DEFAULT_LOGO_SIZE) * 2;
        const brandIconUrl = getBrandIconUrl(domain, retinaSize);
        return brandIconUrl;
      } catch {
        return undefined;
      }

jpople · 2026-02-11T00:23:57Z

@greptileai

greptile-apps

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-11T00:42:15Z

...tures/data-discovery-and-detection/action-center/components/InfrastructureSystemListItem.tsx

+            <Flex className="ml-2">
+              {logoUrl && (
+                <Image
+                  src={logoUrl}
+                  alt={systemName}
+                  preview={false}
+                  width={36}
+                />
+              )}


Broken vendor logo rendering

logoUrl being defined doesn’t guarantee the image will load (404/CORS/network). Since fidesui’s Image is AntD’s Image (no built-in fallback), this will display a broken image instead of the Settings avatar whenever the remote URL fails. Consider using Avatar with src + icon fallback (as in ConnectionTypeLogo) or track onError to swap to the fallback Avatar.

gilluminate · 2026-02-11T16:02:32Z

...tures/data-discovery-and-detection/action-center/components/InfrastructureSystemListItem.tsx

+                <Avatar
+                  shape="square"
+                  size={36}
+                  icon={<Icons.Settings />}
+                  alt={systemName}


Is there a reason we're not using ConnectionTypeLogo here?

gilluminate · 2026-02-11T16:13:53Z

...tures/data-discovery-and-detection/action-center/components/InfrastructureSystemListItem.tsx

+                  src={logoUrl}
+                  alt={systemName}
+                  preview={false}
+                  width={36}


could probably use DEFAULT_LOGO_SIZE here

gilluminate · 2026-02-11T16:14:39Z

...tures/data-discovery-and-detection/action-center/components/InfrastructureSystemListItem.tsx

-            /> */}
+            <Flex className="ml-2">
+              {logoUrl && (
+                <Image


consider adding this as a comment in the code

gilluminate · 2026-02-11T16:16:32Z

...tures/data-discovery-and-detection/action-center/components/InfrastructureSystemListItem.tsx

+        // Try to extract domain from vendor ID or system name
+        const domain = getDomain(vendorId);
+        if (domain) {
+          return getBrandIconUrl(domain, 72); // 18px * 2 for retina


Suggested change

return getBrandIconUrl(domain, 72); // 18px * 2 for retina

return getBrandIconUrl(domain, 72); // 36px * 2 for retina

add logos to Okta monitor results

414c045

jpople requested a review from a team as a code owner February 11, 2026 00:11

jpople requested review from gilluminate and removed request for a team February 11, 2026 00:11

jpople commented Feb 11, 2026

View reviewed changes

greptile-apps bot reviewed Feb 11, 2026

View reviewed changes

clients/admin-ui/src/features/common/utils.ts Outdated Show resolved Hide resolved

clients/admin-ui/src/features/common/utils.ts Show resolved Hide resolved

jpople added 3 commits February 10, 2026 18:17

changelog

7e135a4

add error handling to existing getDomain usage

dd30024

changelog fix

2a8c5dc

greptile-apps bot reviewed Feb 11, 2026

View reviewed changes

gilluminate reviewed Feb 11, 2026

View reviewed changes

	return getBrandIconUrl(domain, 72); // 18px * 2 for retina
	return getBrandIconUrl(domain, 72); // 36px * 2 for retina

Conversation

jpople commented Feb 11, 2026 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description Of Changes

Code Changes

Steps to Confirm

Pre-Merge Checklist

Uh oh!

vercel bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpople Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

gilluminate Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot commented Feb 11, 2026

Uh oh!

jpople commented Feb 11, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

gilluminate Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

gilluminate Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

gilluminate Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

gilluminate Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jpople commented Feb 11, 2026 •

edited by atlassian bot

Loading

vercel bot commented Feb 11, 2026 •

edited

Loading

greptile-apps bot commented Feb 11, 2026 •

edited

Loading