Skip to content

[draft] MSSQL DSR query hint support#7104

Closed
adamsachs wants to merge 2 commits intomainfrom
asachs/ENG-2176
Closed

[draft] MSSQL DSR query hint support#7104
adamsachs wants to merge 2 commits intomainfrom
asachs/ENG-2176

Conversation

@adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Dec 11, 2025

Ticket ENG-2176

Depends on a fideslang update that's pending here: ethyca/fideslang#37

Description Of Changes

Initial shot at a mechanism for supporting 'query hints' on generated DSR queries, specified via configuration on Dataset Collections. The first query hint that would be supported is a MAXDOP hint for MSSQL connectors.

Code Changes

Steps to Confirm

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Dec 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ignored Ignored Dec 11, 2025 2:57am
fides-privacy-center Ignored Ignored Dec 11, 2025 2:57am

@adamsachs
Copy link
Contributor Author

closing PR as we're no longer pursuing this feature at the moment.

@adamsachs adamsachs closed this Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant