[WIP] Initial attempt to validate >256kb ipfs files#165
Open
njgheorghita wants to merge 2 commits intoethpm:masterfrom
Open
[WIP] Initial attempt to validate >256kb ipfs files#165njgheorghita wants to merge 2 commits intoethpm:masterfrom
njgheorghita wants to merge 2 commits intoethpm:masterfrom
Conversation
d6bd74b to
3518370
Compare
Contributor
Author
|
@pipermerriam I've been running down some rabbitholes to get >256kb ipfs file content-hash validation working. If you can take a quick 👀 and see if anything jumps out to you? As far as I can tell, everything's in the right place, but the output hashes just won't match the expected value. I've manually decoded the individual root and leaf ipfs objects, and everything in my code corresponds to the output. i.e.
ipfs object get QmegXsU7EopJ9EVj9ELwgHGE75Xke6FYBP84PaygiAsqB5
{"Links":[{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmbYfXF7A7hgXUzEZSifji3D6Nf856kdK8Edu8n7knQSHr","Size":262158},{"Name":"","Hash":"QmZw2JEKQu8n5zisuU7JDAeWSUm2XvqjqV72bizCdDQUDM","Size":19278}],"Data":"\u0008\u0002\u0018���\u0002 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0010 ��\u0001"}
ipfs object data QmegXsU7EopJ9EVj9ELwgHGE75Xke6FYBP84PaygiAsqB5 | unixfs
{"type":"file","blockSizes":[262144,262144,262144,262144,262144,262144,262144,262144,262144,262144,262144,262144,262144,262144,262144,262144,262144,262144,262144,19264]} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Validating ipfs contents retrieved against their hash is broken for files > 256kb.
useful links:
Cute Animal Picture